[19.0] mail_composer_cc_bcc: Migration to 19.0 by cyrilmanuel · Pull Request #104 · OCA/mail

cyrilmanuel · 2025-11-03T09:28:26Z

No description provided.

…ents when no cc or bcc

Currently translated at 83.3% (15 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/

Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/

Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/

Currently translated at 100.0% (17 of 17 strings) Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/it/

…onstraint "unique_mail_message_id_res_partner_id_if_set" when adding the same user to CC field that is already set as a follower

### This changes 1. Refactor _generate_template_recipients 2. Fix invalid-email-address for Bcc - In standard, Bcc key in dict message was stripped in https://github.com/odoo/odoo/blob/4394940a09900aa5b42cbc05355880598608d1b6/odoo/addons/base/models/ir_mail_server.py#L676 - Duplicate the key to retain for later assertion

Currently translated at 100.0% (17 of 17 strings) Translation: mail-18.0/mail-18.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_composer_cc_bcc/it/

vvrossem

LGTM, I think you can squash [IMP] Update code to match with v19 with [19.0][MIG] mail_composer_cc_bcc: Migration to 19.0.

And while you are at it:

Consider to squash administrative commits (if any) with the previous commit for reducing commit noise. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.

Also, it could be the opportunity to update the .png files (if relevant)

OCA-git-bot · 2025-11-18T12:55:46Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bosd · 2025-11-21T14:58:08Z

@etobella Can you please merge?

tuffstuff9 · 2026-01-04T21:37:44Z

LGTM

visionsrlsolution · 2026-01-22T15:23:26Z

When merge? any ETA? thx

StefanRijnhart · 2026-01-28T11:16:27Z

/ocabot migration mail_composer_cc_bcc

StefanRijnhart · 2026-01-28T11:36:05Z

mail_composer_cc_bcc/models/ir_mail_server.py

+class IrMailServer(models.Model):
+    _inherit = "ir.mail_server"
+
+    def _prepare_email_message(self, message, smtp_session):


Method was renamed: odoo/odoo@e147c778ebbd0#diff-e46e2629963b0ad64aed7a7b02f49caea5bfacd952b77abcb2954f2437c9222aL668-R646. This implies a missing test.

davidepedraii · 2026-03-05T09:54:21Z

Hello, we are experiencing some issues in the Version 19 of Odoo.sh , the issue is that: When sending emails with the BCC Module, we found an issue that when sending an email we encountered that the destination email didnt apparently exist, even if it exist and we have control of it, moreover the email resulted sent from Microsoft Outgoing email, but never recieved from the destination.

giusybloomup · 2026-03-12T10:47:01Z

When merge?
LGTM
thx :-)

StefanRijnhart · 2026-03-12T13:40:40Z

@giusybloomup When the code is fixed

NICO-SOLUTIONS

Reviewing prepare_email_message_ override and updated hash

NICO-SOLUTIONS · 2026-04-08T17:16:52Z

mail_composer_cc_bcc/models/ir_mail_server.py

+class IrMailServer(models.Model):
+    _inherit = "ir.mail_server"
+
+    def _prepare_email_message(self, message, smtp_session):


Suggested change

def _prepare_email_message(self, message, smtp_session):

def _prepare_email_message__(self, message, smtp_session):

An extra double underscore was added to the method

NICO-SOLUTIONS · 2026-04-08T17:17:49Z

mail_composer_cc_bcc/tests/test_mail_cc_bcc.py

+)
+
+VALID_HASHES = {
+    "mail.composer:_compute_partner_ids": ["4e49f0d6c53f41ac24b02176e97b600a"],


Suggested change

"mail.composer:_compute_partner_ids": ["4e49f0d6c53f41ac24b02176e97b600a"],

"mail.composer:_compute_partner_ids": ["c3903ab78bf2e5d9aba078ac2689d974"],

Updated hash to match the current upstream _compute_partner_ids

NICO-SOLUTIONS · 2026-04-08T17:24:34Z

mail_composer_cc_bcc/models/ir_mail_server.py

+        if x_odoo_bcc_value:
+            message["Bcc"] = x_odoo_bcc_value
+
+        smtp_from, smtp_to_list, message = super()._prepare_email_message(


Suggested change

smtp_from, smtp_to_list, message = super()._prepare_email_message(

smtp_from, smtp_to_list, message = super()._prepare_email_message__(

Call updated prepare_email_message_ method with extra double underscore

hailangvn and others added 30 commits November 3, 2025 09:50

[ADD] mail_composer_cc_bcc: send email to cc, bcc addresses

2c9d510

[FIX] avoid confusion of email's partners

73b4b37

[ADD] icon.png

3e9da94

[FIX]mail_composer_cc_bcc: avoid sending multiple mails to all recipi…

de71db4

…ents when no cc or bcc

[FIX] mail_composer_cc_bcc: don't impact mass_mailing

f8519b5

[FIX] mail_composer_cc_bcc: changes upstream

3983f93

[MIG] mail_composer_cc_bcc: Migrate to version 16.0

186a9ee

[UPD] Update mail_composer_cc_bcc.pot

8c0011a

Added translation using Weblate (Spanish)

c7a1053

Translated using Weblate (Spanish)

536652a

Currently translated at 83.3% (15 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/

Translated using Weblate (Spanish)

4e1a93a

Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/

Added translation using Weblate (Italian)

b365dff

Translated using Weblate (Italian)

26ec415

Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/it/

[FIX] mail_composer_cc_bcc: find invoice regardless of the current year

41b907f

[BOT] post-merge updates

ea0d4c0

[UPD] mail_composer_cc_bcc: propose maintainer

1abe7c6

[IMP] mail_composer_cc_bcc: pre-commit

dab5b2e

[MIG] mail_composer_cc_bcc: Migration to 17.0

f20c606

[IMP] mail_composer_cc_bcc_account: pre-commit

316b730

[MIG] mail_composer_cc_bcc_account: Migration to 17.0

4f52809

[UPD] Update mail_composer_cc_bcc.pot

a34c285

[BOT] post-merge updates

237063f

Update translation files

fb4785b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/

Translated using Weblate (Italian)

588354d

Currently translated at 100.0% (17 of 17 strings) Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/it/

[FIX] mail_composer_cc_bcc: fix duplicate key value violates unique c…

35b9a17

…onstraint "unique_mail_message_id_res_partner_id_if_set" when adding the same user to CC field that is already set as a follower

[FIX] mail_composer_cc_bcc:send RFQ by email

f247816

[FIX] mail_composer_cc_bcc: duplicate email

75ac264

[IMP] mail_composer_cc_bcc: pre-commit execution

d162abb

[MIG] mail_composer_cc_bcc: Migration to 18.0

7564df5

Translated using Weblate (Italian)

4eaeeda

Currently translated at 100.0% (17 of 17 strings) Translation: mail-18.0/mail-18.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_composer_cc_bcc/it/

cyrilmanuel force-pushed the 19.0-mail_composer_cc_bcc branch from 73bfe5f to af5d8f3 Compare November 3, 2025 09:50

imlopes force-pushed the 19.0-mail_composer_cc_bcc branch from e653654 to 6442af0 Compare November 14, 2025 12:46

vvrossem approved these changes Nov 18, 2025

View reviewed changes

imlopes approved these changes Nov 18, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 18, 2025

imlopes force-pushed the 19.0-mail_composer_cc_bcc branch 2 times, most recently from c0cbcf5 to 60c3aa7 Compare November 19, 2025 11:15

[19.0][MIG] mail_composer_cc_bcc: Migration to 19.0

3877021

yankinmax force-pushed the 19.0-mail_composer_cc_bcc branch from b2a4020 to 3877021 Compare November 20, 2025 18:26

jdidderen mentioned this pull request Dec 10, 2025

[19.0][MIG] mail_composer_cc_bcc_account: Migration to 19.0 #122

Open

AungKoKoLin1997 mentioned this pull request Dec 11, 2025

[19.0][MIG] mail_composer_cc_bcc #113

Closed

StefanRijnhart changed the title ~~19.0 mail composer cc bcc~~ 19.0 mail_composer_cc_bcc Jan 28, 2026

StefanRijnhart changed the title ~~19.0 mail_composer_cc_bcc~~ [19.0] mail_composer_cc_bcc: Migration to 19.0 Jan 28, 2026

OCA-git-bot added this to the 19.0 milestone Jan 28, 2026

OCA-git-bot mentioned this pull request Jan 28, 2026

Migration to version 19.0 #85

Open

33 tasks

StefanRijnhart reviewed Jan 28, 2026

View reviewed changes

NICO-SOLUTIONS suggested changes Apr 8, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 8, 2026

	def _prepare_email_message(self, message, smtp_session):
	def _prepare_email_message__(self, message, smtp_session):

	"mail.composer:_compute_partner_ids": ["4e49f0d6c53f41ac24b02176e97b600a"],
	"mail.composer:_compute_partner_ids": ["c3903ab78bf2e5d9aba078ac2689d974"],

	smtp_from, smtp_to_list, message = super()._prepare_email_message(
	smtp_from, smtp_to_list, message = super()._prepare_email_message__(

Uh oh!

Conversation

cyrilmanuel commented Nov 3, 2025

Uh oh!

vvrossem left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 18, 2025

Uh oh!

bosd commented Nov 21, 2025

Uh oh!

tuffstuff9 commented Jan 4, 2026

Uh oh!

visionsrlsolution commented Jan 22, 2026

Uh oh!

StefanRijnhart commented Jan 28, 2026

Uh oh!

StefanRijnhart Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

davidepedraii commented Mar 5, 2026

Uh oh!

giusybloomup commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Mar 12, 2026

Uh oh!

NICO-SOLUTIONS left a comment

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

NICO-SOLUTIONS Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

giusybloomup commented Mar 12, 2026 •

edited

Loading

NICO-SOLUTIONS Apr 8, 2026 •

edited

Loading

NICO-SOLUTIONS Apr 8, 2026 •

edited

Loading