Skip to content

[18.0][MIG] quality_control_mrp_oca: Migration to 18.0#1736

Open
alfredoavanzosc wants to merge 28 commits intoOCA:18.0from
alfredoavanzosc:18.0-mig-quality_control_mrp_oca
Open

[18.0][MIG] quality_control_mrp_oca: Migration to 18.0#1736
alfredoavanzosc wants to merge 28 commits intoOCA:18.0from
alfredoavanzosc:18.0-mig-quality_control_mrp_oca

Conversation

@alfredoavanzosc
Copy link
Copy Markdown
Contributor

No description provided.

@alfredoavanzosc alfredoavanzosc force-pushed the 18.0-mig-quality_control_mrp_oca branch 2 times, most recently from 5b14623 to 75fa9b6 Compare February 23, 2026 09:50
@alfredoavanzosc
Copy link
Copy Markdown
Contributor Author

@remi-filament ... review please.

Copy link
Copy Markdown
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alfredoavanzosc
LGTM, Code review

Copy link
Copy Markdown
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit from pre-commit is missing, you should split the current one in two.

@alfredoavanzosc alfredoavanzosc force-pushed the 18.0-mig-quality_control_mrp_oca branch from 75fa9b6 to 42f47bc Compare April 1, 2026 07:00
@alfredoavanzosc
Copy link
Copy Markdown
Contributor Author

The commit from pre-commit is missing, you should split the current one in two.

Thank you very much @sergiocorato , I have already done what you asked.

@sergiocorato
Copy link
Copy Markdown
Contributor

The commit from pre-commit is missing, you should split the current one in two.

Thank you very much @sergiocorato , I have already done what you asked.

Could you explain please? I see in the migration commit changes made from pre-commit.

pedrobaeza and others added 21 commits April 1, 2026 12:14
…README files, and new concepts. WIP of quality_control_tolerance

[FIX] quality_control: Triggers for product category
[IMP] quality_control_mrp: Smartbutton to inspections
[IMP] quality_control_mrp: required changes
* Limit access by groups in views
* Use api.model
…inspections

When an inspection was created, it wasn't ignoring the cancelled moves.
quality_control_mrp: tests extended

[IMP] quality_control_mrp: take product from manufacturing order

[IMP] quality_control_mrp: removed not required code

[FIX] quality_control_mrp: expected singleton error

[FIX] quality_control_mrp: partial fabrications where creating more inspections than required
@alfredoavanzosc alfredoavanzosc force-pushed the 18.0-mig-quality_control_mrp_oca branch from 42f47bc to de526a5 Compare April 1, 2026 10:22
@alfredoavanzosc alfredoavanzosc force-pushed the 18.0-mig-quality_control_mrp_oca branch 2 times, most recently from 8e5cf6d to 1c998cf Compare April 1, 2026 10:31
@alfredoavanzosc
Copy link
Copy Markdown
Contributor Author

@sergiocorato review please.

Copy link
Copy Markdown
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pre-commit did nothing before migration?
Anyway it's good for me.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

clementmbr

This comment was marked as outdated.

Copy link
Copy Markdown
Member

@clementmbr clementmbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need this small fix @alfredoavanzosc

<record id="action_qc_inspection_per_production" model="ir.actions.act_window">
<field name="name">Quality inspections from production order</field>
<field name="res_model">qc.inspection</field>
<field name="view_mode">tree,form</field>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="view_mode">tree,form</field>
<field name="view_mode">list,form</field>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction made. Thank you very much.

@alfredoavanzosc alfredoavanzosc force-pushed the 18.0-mig-quality_control_mrp_oca branch from 1c998cf to 03546b4 Compare April 7, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.