[18.0][FIX] product_multi_company_stock: Adding a company to a product must not affect existing lots#991
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Apr 24, 2026
Conversation
OCA-git-bot
added
series:18.0
mod:product_multi_company_stock
LoisRForgeFlow
force-pushed
the
18.0-fix-product_multi_company_stock
branch
3 times, most recently
from
ba9cb2a to
e74af12
Compare
DavidJForgeFlow
approved these changes
Apr 22, 2026
ThiagoMForgeFlow
approved these changes
Apr 24, 2026
JoanSForgeFlow
approved these changes
Apr 24, 2026
LoisRForgeFlow
force-pushed
the
18.0-fix-product_multi_company_stock
branch
2 times, most recently
from
18d76f6 to
272e51f
Compare
… not affect existing lots Bug: adding a new company to a product's company_ids triggers a recompute of stock.lot.company_id (which depends on product_id.company_id). Both lots evaluate product_id.company_id in the same env context, so they end up with the same company_id, causing _check_unique_lot to raise a ValidationError even though no lot data changed.
LoisRForgeFlow
force-pushed
the
18.0-fix-product_multi_company_stock
branch
from
272e51f to
c621733
Compare
Contributor
Author
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 12dece4. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: adding a new company to a product's company_ids triggers a recompute of stock.lot.company_id (which depends on product_id.company_id). Both lots evaluate product_id.company_id in the same env context, so they end up with the same company_id, causing _check_unique_lot to raise a ValidationError even though no lot data changed.