Skip to content

Fix pre commit ci update config slg#339

Merged
sbidoul merged 5 commits intoOCA:masterfrom
grap:FIX-pre-commit-ci-update-config-SLG
Mar 31, 2026
Merged

Fix pre commit ci update config slg#339
sbidoul merged 5 commits intoOCA:masterfrom
grap:FIX-pre-commit-ci-update-config-SLG

Conversation

@legalsylvain
Copy link
Copy Markdown
Collaborator

@legalsylvain legalsylvain commented Mar 31, 2026

supersed : #309

  • bump version for last pre-commit tools
  • replace flake8 + black by ruff

apply changes and fix pre-commit errors.

rebased on top of recent merged PRs : #329, #332, #333, #334, #335, #336, #337

pre-commit-ci bot and others added 3 commits March 31, 2026 11:29
updates:
- https://github.com/psf/blackhttps://github.com/psf/black-pre-commit-mirror
- [github.com/psf/black-pre-commit-mirror: 24.10.0 → 26.3.1](psf/black-pre-commit-mirror@24.10.0...26.3.1)
- [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)
- [github.com/pycqa/flake8: 7.1.1 → 7.3.0](PyCQA/flake8@7.1.1...7.3.0)
- [github.com/asottile/pyupgrade: v3.18.0 → v3.21.2](asottile/pyupgrade@v3.18.0...v3.21.2)
- [github.com/PyCQA/isort: 5.13.2 → 8.0.1](PyCQA/isort@5.13.2...8.0.1)
fix-encoding-pragma has been removed -- use pyupgrade from https://github.com/asottile/pyupgrade
@legalsylvain legalsylvain force-pushed the FIX-pre-commit-ci-update-config-SLG branch 2 times, most recently from 0cd1d6a to 4ee0a36 Compare March 31, 2026 10:01
…it files.

[IMP] replace black + flake8 + pyupgrade + seed-isort-config + isort by ruff. (like in other OCA repo)
@legalsylvain legalsylvain force-pushed the FIX-pre-commit-ci-update-config-SLG branch from 4ee0a36 to 1698def Compare March 31, 2026 10:08
Copy link
Copy Markdown
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little remark

f"https://github.com/{org}/{repo}/raw/{branch}/{addon}/{manifest_file}"
)
_logger.debug("Looking for maintainers in %s" % url)
_logger.debug(f"Looking for maintainers in {url}")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was wrong before. Use , instead.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Thanks for your quick review !

@legalsylvain legalsylvain force-pushed the FIX-pre-commit-ci-update-config-SLG branch from 1698def to b4c8e30 Compare March 31, 2026 11:12
@legalsylvain legalsylvain force-pushed the FIX-pre-commit-ci-update-config-SLG branch from b4c8e30 to 00ad383 Compare March 31, 2026 11:12
Copy link
Copy Markdown

@Honeyxilia Honeyxilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review OK

@sbidoul sbidoul merged commit 4b71b16 into OCA:master Mar 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants