Skip to content

[IMP] tools.get_file to support single extension #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] tools.get_file to support single extension #123

wants to merge 1 commit into from

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy commented Nov 27, 2024 •
edited
Loading

try to run tests on master branch when add security folder: coverage run --source=odoo_module_migrate -m unittest discover -s tests

  • before:
2024-11-27 17:47:37,655,655 odoo_module_migrate.log INFO Run pre-commit
2024-11-27 17:47:38,318,318 odoo_module_migrate.log INFO [module_170] Running migration from 17.0 to 18.0
2024-11-27 17:47:38,323,323 odoo_module_migrate.log INFO Set module installable
2024-11-27 17:47:38,323,323 odoo_module_migrate.log INFO Bump version to 18.0.1.0.0
2024-11-27 17:47:38,352,352 odoo_module_migrate.log INFO Updated chatter blocks in file: /home/trobz/code/oca/odoo-module-migrator/tests/data_tmp/module_170/views/res_partner.xml
2024-11-27 17:47:38,353,353 odoo_module_migrate.log ERROR Error processing file /home/trobz/code/oca/odoo-module-migrator/tests/data_tmp/module_170/security: [Errno 21] Is a directory: '/home/trobz/code/oca/odoo-module-migrator/tests/data_tmp/module_170/security'
2024-11-27 17:47:38,355,355 odoo_module_migrate.log INFO Changing content of file: res_partner.py
  • after:
2024-11-27 17:48:13,138,138 odoo_module_migrate.log INFO Run pre-commit
2024-11-27 17:48:13,816,816 odoo_module_migrate.log INFO [module_170] Running migration from 17.0 to 18.0
2024-11-27 17:48:13,821,821 odoo_module_migrate.log INFO Set module installable
2024-11-27 17:48:13,821,821 odoo_module_migrate.log INFO Bump version to 18.0.1.0.0
2024-11-27 17:48:13,849,849 odoo_module_migrate.log INFO Updated chatter blocks in file: /home/trobz/code/oca/odoo-module-migrator/tests/data_tmp/module_170/views/res_partner.xml
2024-11-27 17:48:13,851,851 odoo_module_migrate.log INFO Changing content of file: res_partner.py

@xaviedoanhduy xaviedoanhduy changed the title [IMP]: tools.get_file to support single extension [IMP] tools.get_file to support single extension Nov 27, 2024
@xaviedoanhduy xaviedoanhduy marked this pull request as draft November 27, 2024 10:57
@xaviedoanhduy xaviedoanhduy marked this pull request as ready for review November 28, 2024 04:30
lef-adhoc
lef-adhoc approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lef-adhoc lef-adhoc lef-adhoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaviedoanhduy @lef-adhoc