[UPG] Base migration upgrade for fields rename. #125

BT-dherreros · 2024-12-13T16:09:42Z

No description provided.

odoo_module_migrate/base_migration_script.py

bosd

Code review of the fix. No func test yet.

BT-rmartin · 2025-04-03T08:54:56Z

@CLaurelB @legalsylvain @lef-adhoc Could you please review this PR?

BT-dherreros · 2025-04-25T14:27:17Z

@CLaurelB @legalsylvain @lef-adhoc I've updated this code with master, cleaned it slightly and also introduced data to be tested so the code coverage is improved

BT-rmartin

Excellent job!

OCA-git-bot · 2025-04-26T00:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BT-rmartin · 2025-05-05T15:05:02Z

@gurneyalex @dreispt @simahawk Could you please review and merge it?

sebalix · 2025-05-06T08:56:16Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_150_160/utm.yaml

@@ -0,0 +1 @@
+- ["utm.campaign", "name", "title", "Commit https://github.com/brain-tec/odoo/commit/4dbcefb5e5b1878e81fe9be9fe48a785f813334f"]


Suggested change

- ["utm.campaign", "name", "title", "Commit https://github.com/brain-tec/odoo/commit/4dbcefb5e5b1878e81fe9be9fe48a785f813334f"]

- ["utm.campaign", "name", "title", "Commit https://github.com/odoo/odoo/commit/4dbcefb5e5b1878e81fe9be9fe48a785f813334f"]

sebalix · 2025-05-06T08:56:46Z

odoo_module_migrate/migration_scripts/renamed_models/migrate_150_160/renamed_models.yaml

@@ -1 +1 @@
- ["stock.production.lot", "stock.lot", None]
+- ["stock.production.lot", "stock.lot", "c1b41bcd08ea26032904b3fdd34d743f4342ac62"]


Suggested change

- ["stock.production.lot", "stock.lot", "c1b41bcd08ea26032904b3fdd34d743f4342ac62"]

- ["stock.production.lot", "stock.lot", "https://github.com/odoo/odoo/commit/c1b41bcd08ea26032904b3fdd34d743f4342ac62"]

⚠️ but the commit is wrong (not related to stock.lot)

sebalix · 2025-05-06T09:03:20Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_150_160/inventory.yaml

@@ -0,0 +1 @@
+- ["product.supplierinfo", "name", "partner_id", "Commit https://github.com/odoo/odoo/commit/f3fe2d50d99698eb0261c2309bd63f9f64b3d703"]


the name of the file should be product.yaml I guess

sebalix · 2025-05-06T09:04:46Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_140_150/payment.yaml

@@ -0,0 +1 @@
+- ["payment.transaction", "date", "last_state_change", "Commit https://github.com/odoo/odoo/commit/f3fe2d50d99698eb0261c2309bd63f9f64b3d703"]


The commit seems not the right one ⚠️

sebalix · 2025-05-06T09:07:41Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_140_150/calendar.yaml

+- ["calendar.event", "mo", "mon", "Commit https://github.com/odoo/odoo/commit/7fb9c8129606538b004dea4e6ad071eabf6c6fb1"]
+- ["calendar.event", "we", "wed", "Commit https://github.com/odoo/odoo/commit/7fb9c8129606538b004dea4e6ad071eabf6c6fb1"]
+- ["calendar.recurrence", "mo", "mon", "Commit https://github.com/odoo/odoo/commit/7fb9c8129606538b004dea4e6ad071eabf6c6fb1"]
+- ["calendar.recurrence", "we", "wed", "Commit https://github.com/odoo/odoo/commit/7fb9c8129606538b004dea4e6ad071eabf6c6fb1"]


You listed only Monday and Wednesday here, we are missing the other days of the week for both calendar.event and calendar.recurrence, see:
odoo/odoo@7fb9c81#diff-6f507918d49ed37455fca2208ee1d5c546bd6368371d99cf261c8bc4d167a160

sebalix · 2025-05-06T09:11:47Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/payment.yaml

@@ -0,0 +1 @@
+- ["payment.acquirer", "image", "image_128", "Commit https://github.com/odoo/odoo/commit/f0ffbea17381cb117f2eed4ea18a76e2b0f37f00"]


Should we add also image_64? I won't block for that as we are talking about 12.0/13.0 here, up to you.

sebalix · 2025-05-06T09:15:35Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/inventory.yaml

@@ -0,0 +1 @@
+- ["product.attribute", "type", "display_type", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]


Commit seems wrong, and the file should be named differently too

sebalix · 2025-05-06T09:16:36Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/hr.yaml

@@ -0,0 +1 @@
+- ["hr.plan.activity.type", "name", "summary", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]


Commit seems wrong

sebalix · 2025-05-06T09:19:05Z

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/base.yaml

@@ -0,0 +1,2 @@
+- ["image.mixin", "image_original", "image_1920", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]
+- ["mail.channel", "image", "image_128", "Commit https://github.com/odoo/odoo/commit/f0ffbea17381cb117f2eed4ea18a76e2b0f37f00"]


From the commit, it's image_medium (not image) that became image_128 (and also image_small -> image_64)

@sebalix I don't see image_medium in that commit, could you link the line you are referencing?

sebalix · 2025-05-06T09:20:17Z

odoo_module_migrate/migration_scripts/removed_models/migrate_140_150/removed_models.yaml

+- ["stock.inventory", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]
+- ["stock.inventory.line", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]


Suggested change

- ["stock.inventory", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]

- ["stock.inventory.line", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]

- ["stock.inventory", "Commit https://github.com/odoo/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]

- ["stock.inventory.line", "Commit https://github.com/odoo/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]

BT-dherreros force-pushed the upg-add-field-rename branch from b18e530 to 72db965 Compare December 13, 2024 16:15

bosd reviewed Jan 2, 2025

View reviewed changes

odoo_module_migrate/base_migration_script.py Show resolved Hide resolved

BT-dherreros force-pushed the upg-add-field-rename branch from 72db965 to 6b23df0 Compare January 3, 2025 08:20

bosd approved these changes Jan 4, 2025

View reviewed changes

bosd mentioned this pull request Jan 26, 2025

base_migration_script.py, line 230: UnboundLocalError: local variable 'new_text' referenced before assignment #129

Open

BT-dherreros force-pushed the upg-add-field-rename branch 3 times, most recently from 44574c7 to 9c274be Compare April 25, 2025 14:25

BT-rmartin approved these changes Apr 25, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 25, 2025

sebalix reviewed May 6, 2025

View reviewed changes

[UPG] Base migration upgrade for fields rename.

9c221c6

BT-dherreros force-pushed the upg-add-field-rename branch from 9c274be to 9c221c6 Compare May 27, 2025 14:39

		@@ -0,0 +1 @@
		- ["utm.campaign", "name", "title", "Commit https://github.com/brain-tec/odoo/commit/4dbcefb5e5b1878e81fe9be9fe48a785f813334f"]

		@@ -1 +1 @@
		- ["stock.production.lot", "stock.lot", None]
		- ["stock.production.lot", "stock.lot", "c1b41bcd08ea26032904b3fdd34d743f4342ac62"]

		@@ -0,0 +1 @@
		- ["product.supplierinfo", "name", "partner_id", "Commit https://github.com/odoo/odoo/commit/f3fe2d50d99698eb0261c2309bd63f9f64b3d703"]

		@@ -0,0 +1 @@
		- ["payment.transaction", "date", "last_state_change", "Commit https://github.com/odoo/odoo/commit/f3fe2d50d99698eb0261c2309bd63f9f64b3d703"]

		@@ -0,0 +1 @@
		- ["payment.acquirer", "image", "image_128", "Commit https://github.com/odoo/odoo/commit/f0ffbea17381cb117f2eed4ea18a76e2b0f37f00"]

		@@ -0,0 +1 @@
		- ["product.attribute", "type", "display_type", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]

		@@ -0,0 +1 @@
		- ["hr.plan.activity.type", "name", "summary", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]

		@@ -0,0 +1,2 @@
		- ["image.mixin", "image_original", "image_1920", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]
		- ["mail.channel", "image", "image_128", "Commit https://github.com/odoo/odoo/commit/f0ffbea17381cb117f2eed4ea18a76e2b0f37f00"]

		- ["stock.inventory", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]
		- ["stock.inventory.line", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]

Uh oh!

[UPG] Base migration upgrade for fields rename. #125

Are you sure you want to change the base?

[UPG] Base migration upgrade for fields rename. #125

Uh oh!

Conversation

BT-dherreros commented Dec 13, 2024

Uh oh!

Uh oh!

bosd left a comment

Choose a reason for hiding this comment

Uh oh!

BT-rmartin commented Apr 3, 2025

Uh oh!

BT-dherreros commented Apr 25, 2025

Uh oh!

BT-rmartin left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 26, 2025

Uh oh!

BT-rmartin commented May 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebalix May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sebalix May 6, 2025 •

edited

Loading