[16.0][ADD] pos_auto_invoice

[huguesdk]

module to set point-of-sale orders as to-invoice by default.

[legalsylvain]

hi @huguesdk. Thanks for this contribution.

At a first look, LGTM to me.
some remarks :

• Is it possible to add a boolean auto_invoice_by_default on pos.config and base the change in the PoS regarding that new flag ? Pro :
• -> it will be installable on multi-company or multi-pos-config context, because such default auto_invoice is great but can be limited to some pos.config.
• -> we can disable it on demo data, to avoid "excude" mechanism on CI.

What do you think ?

[huguesdk]

i completely agree. like this?

do you think that it should be enabled by default and disabled by demo data? i think that disabled by default makes sense, especially since having a different default behavior with and without demo data could be confusing for users.

[legalsylvain]

do you think that it should be enabled by default and disabled by demo data? i think that disabled by default makes sense, especially since having a different default behavior with and without demo data could be confusing for users

totally agree!

[huguesdk]

thanks a lot for the review! i added your suggestion to avoid variable shadowing.

i also ensured that the value of to_invoice is kept for existing orders. strangely, the default behavior in init_from_JSON() is to always set it to false, although it is correctly handled in export_as_JSON().

[legalsylvain]

Thanks !

[polchampion]

successful functional test on rotor-v16-test

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[huguesdk]

@OCA/pos-maintainers would someone please merge this?

[legalsylvain]

/ocabot merge nobump

[huguesdk]

@legalsylvain thanks! but it doesn’t seem to work. is ocabot sleeping? ☺️

[legalsylvain]

hi @huguesdk.

Related to OCA/odoo-community.org#204 (comment) maybe ?

[huguesdk]

@legalsylvain would you please try again?

[legalsylvain]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1258-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 898aba4. Thanks a lot for contributing to OCA. ❤️