[17.0][MIG] pos_payment_change: Migration to 17.0#1264
Closed
[17.0][MIG] pos_payment_change: Migration to 17.0#1264
Conversation
sylvainvh
force-pushed
the
17.0-mig-pos_payment_change
branch
from
c7e1b22 to
b4f276f
Compare
lauradiaz22
approved these changes
Nov 29, 2024
lauradiaz22
left a comment
lauradiaz22
left a comment
There was a problem hiding this comment.
Functional review and this LGTM👍
sylvainvh
force-pushed
the
17.0-mig-pos_payment_change
branch
from
b4f276f to
a71b475
Compare
Member
|
Hi @sylvainvh , could you please rebase? |
DorianMAG
reviewed
Feb 6, 2025
DorianMAG
left a comment
DorianMAG
left a comment
There was a problem hiding this comment.
Technical Review,
It seems good.
I can't do a functional review,
Is it possible to rebase please?
Thank you.
Author
|
Hello, I'll rebase my branch now |
- Black python code - OCA Convention - Add tests - add configuration on pos.config, with two option 'refund' or 'update' - The 'refund' option makes the module compatible with (French) certification - make the module compatible with pos_order_return
…on PoS Order(s) to know the history of the payments
…ontrol ; [ADD] display old payment lines
Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/
add new line Pylint fix pylint
Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/
Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/
A cash payment method must have a cash journal.
Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/
Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/
Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/
Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/
In old version, two certifications modules was present in odoo. l10n_fr_pos_cert and l10n_fr_certification. In odoo 16, only l10n_fr_pos_cert exists.
…e obsolete Warning
Better readme FIX OCA#1115
sylvainvh
force-pushed
the
17.0-mig-pos_payment_change
branch
from
a71b475 to
d4e0c15
Compare
Author
|
Done :) |
DorianMAG
approved these changes
Feb 6, 2025
DorianMAG
left a comment
DorianMAG
left a comment
There was a problem hiding this comment.
Functional test.
LGTM
Thx for this work
Contributor
|
hi @sylvainvh . could you take a look on red CI ? Thanks ! |
|
Can you push again please @sylvainvh ? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.