[16.0] pos_receipt_replace_user_by_trigram: Drop compute function #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
changed the title
The compute function does not allow any customization on how the trigram had to be generated, and there a multiple ways to define how trigram must be generated. Moreover, the compute did generate duplicates and there was no way to fix manually since the field was not stored. Also, making it stored but still computed did risk unwanted updates in case name was updated. Having a basic stored field allows each company to customize how trigram can be generated using a server action. The logic previously provided is then moved to a cron that can be customized to suit trigram generation for each company.
grindtildeath
force-pushed
the
16.0-imp-remove_trigram_compute
branch
from
a2aee40 to
a1740b2
Compare
Contributor
Author
trisdoan
approved these changes
Dec 11, 2024
Contributor
trisdoan
left a comment
trisdoan
left a comment
There was a problem hiding this comment.
Sounds like a great idea to me! Thanks
Could you squash the fixup?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Contributor
Author
|
@OCA/pos-maintainers anyone to reopen please 🙏 |
|
Github's not letting me :/ :
Could you re-create the PR, I'll review & merge asap, given that this one already had one approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compute function does not allow any customization on how the trigram had to be generated, and there a multiple ways to define how trigram must be generated.
Moreover, the compute did generate duplicates and there was no way to fix manually since the field was not stored. Also, making it stored but still computed did risk unwanted updates in case name was updated.
Having a basic stored field allows each company to customize how trigram can be generated using a server action. The logic previously provided is then moved to a cron that can be customized to suit trigram generation for each company.