[17.0][ADD] Add pos_partner_birthdate_warning module #1338

parvezqureshi · 2025-03-19T04:48:27Z

No description provided.

cvinh

Why don't you simply load res_partner.age field that is already computed in partner_contact_birthdate instead of recompute it ? Is it because it's not stored ?

parvezqureshi · 2025-03-19T05:40:56Z

Why don't you simply load res_partner.age field that is already computed in partner_contact_birthdate instead of recompute it ? Is it because it's not stored ?

@cvinh @vehi-invitu They failed in some cases like the one below.

Customer:

Birthdate = 20-Mar-2007
Current Date = 19-Mar-2025
In the POS screen, the age displays as 17y

Issue:

If the session is closed on 21-Mar-2025 or later, the age should update to 18y on 20-Mar-2025.
However, if the POS screen is not refreshed, it will still display 17y, even after the birthday has passed.

Conclusion:

res_partner.age does not correctly handle cases where the session is not closed daily, leading to outdated age calculations on the POS screen

cvinh · 2025-05-13T08:52:19Z

@parvezqureshi can you please rebase (as runboat is stuck)

parvezqureshi · 2025-05-13T09:19:43Z

@parvezqureshi can you please rebase (as runboat is stuck)

Rebased

cvinh

Thanks for the PR.
Here's are steps that do not work as expected (warning is bypassed) :

the partner does not have a birthdate
we edit the partner and add the birthdate.
we save the partner and it's immediatly selected in the pos order without the warning

cvinh · 2025-05-13T09:49:24Z

I just realize that this module should be renamed to pos_customer_age_warning ... or pos_customer_birthdate_age_warning...

pos_customer_birthdate_warning is meant to warn if it's the customer's birthday ...

WDYT ? @legalsylvain

This can help perfs when there are templates with a lot of variants. Also this adds a "confirm" button that can be a practical alternative to the variant selection.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/

Signed-off-by: Luis Malta <[email protected]>

Currently translated at 100.0% (9 of 9 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/

Currently translated at 100.0% (9 of 9 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-17.0/pos-17.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_product_template/

Co-authored-by: Iván Todorovich <[email protected]>

Currently translated at 37.5% (3 of 8 strings) Translation: pos-14.0/pos-14.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_margin/it/

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_margin/it/

Currently translated at 100.0% (3 of 3 strings) Translation: pos-17.0/pos-17.0-pos_partner_vat_valid Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_partner_vat_valid/it/

…rning

parvezqureshi · 2025-05-15T05:45:32Z

supersede #1382

parvezqureshi mentioned this pull request Mar 19, 2025

[17.0][ADD] Add pos_partner_birthdate_warning module #1333

Draft

parvezqureshi force-pushed the 17.0_pos_partner_birthdate_warning branch from 096d74b to dd800da Compare March 19, 2025 05:02

cvinh reviewed Mar 19, 2025

View reviewed changes

parvezqureshi force-pushed the 17.0_pos_partner_birthdate_warning branch from dd800da to a4d8c27 Compare May 13, 2025 09:16

cvinh suggested changes May 13, 2025

View reviewed changes

parvezqureshi force-pushed the 17.0_pos_partner_birthdate_warning branch from a4d8c27 to 53c00b9 Compare May 13, 2025 12:26

Pierrick Brun and others added 20 commits May 13, 2025 17:57

[IMP] allow to hide the variants in a product template selection

3f2a999

This can help perfs when there are templates with a lot of variants. Also this adds a "confirm" button that can be a practical alternative to the variant selection.

[UPD] Update pos_product_template.pot

813d870

pos_product_template 14.0.1.0.2

e61008d

Update translation files

d4f8f25

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/

[IMP] pos_product_template: Sort product attribute by sequence

5cb7886

[IMP] Allows SelectVariantPopup to be updated when chained to itself

b56029d

Signed-off-by: Luis Malta <[email protected]>

Translated using Weblate (Italian)

9707bc1

Currently translated at 100.0% (9 of 9 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/

pos_product_template 14.0.1.0.3

4c49bd4

Translated using Weblate (Spanish)

2739ce1

Currently translated at 100.0% (9 of 9 strings) Translation: pos-14.0/pos-14.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/es/

[UPD] README.rst

ad11483

[IMP] pos_product_template: black, isort, prettier

3e7222f

[MIG] pos_product_template: Migration to 15.0

916e2db

[UPD] Update pos_product_template.pot

c463d10

[IMP] pos_product_template: pre-commit auto fixes

f48a78e

[MIG] pos_product_template: Migration to 17.0

df80227

[MIG] pos_product_template: Finish migration

728df74

Update copier: Add rebel module for pos_lot_barcode

1ebbf8c

[UPD] Update pos_product_template.pot

9ca4b79

[BOT] post-merge updates

69413e2

Update translation files

71de16a

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-17.0/pos-17.0-pos_product_template Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_product_template/

legalsylvain and others added 27 commits May 13, 2025 17:57

[IMP] pos_margin : display margin and margin rate in front-end UI

5db83f6

Co-authored-by: Iván Todorovich <[email protected]>

[MIG] pos_margin: Migration to 13.0

c373220

[IMP] pos_margin: isort, black, prettier.

27b7e16

[MIG] Migrate module pos_margin to v14.

1a0006f

pos_margin: bump version to workround PyPI glitch

8253be9

[IMP] update dotfiles [ci skip]

4443a3d

Translated using Weblate (Italian)

2b01ab9

Currently translated at 37.5% (3 of 8 strings) Translation: pos-14.0/pos-14.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_margin/it/

[FIX] Hide margin in Front End if config is false

504ec18

pos_margin 14.0.1.0.2

3b65875

Translated using Weblate (Italian)

016eb2a

Currently translated at 37.5% (3 of 8 strings) Translation: pos-14.0/pos-14.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_margin/it/

[IMP] : pre-commit stuff

fa22d62

[MIG] pos_margin: Migration to 16.0

a35dac5

[UPD] Update pos_margin.pot

735ce55

[UPD] README.rst

ab7d539

pos_margin 16.0.1.0.1

b2104ce

Added translation using Weblate (Italian)

cf7fda7

Translated using Weblate (Italian)

e2cc850

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_margin Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_margin/it/

[UPD] README.rst

dba147a

[FIX] eslint error 'no-shadow' in all modules

e3feae4

[BOT] post-merge updates

1acfa39

[IMP] pos_margin: pre-commit execution

ab5f4b5

[MIG] pos_margin: Migration to 17.0

ccffd7d

[UPD] Update pos_margin.pot

23782eb

[BOT] post-merge updates

136eabf

Translated using Weblate (Italian)

90d4d7d

Currently translated at 100.0% (3 of 3 strings) Translation: pos-17.0/pos-17.0-pos_partner_vat_valid Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_partner_vat_valid/it/

[17.0][ADD] Add pos_partner_birthdate_warning module

f4bdb3a

[RENAME] Renamed pos_partner_birthdate_warning to pos_customer_age_wa…

6d05ca7

…rning

parvezqureshi force-pushed the 17.0_pos_partner_birthdate_warning branch from 53c00b9 to 6d05ca7 Compare May 14, 2025 10:18

parvezqureshi closed this May 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[17.0][ADD] Add pos_partner_birthdate_warning module #1338

[17.0][ADD] Add pos_partner_birthdate_warning module #1338

Uh oh!

parvezqureshi commented Mar 19, 2025

Uh oh!

cvinh left a comment

Uh oh!

parvezqureshi commented Mar 19, 2025

Uh oh!

cvinh commented May 13, 2025

Uh oh!

parvezqureshi commented May 13, 2025

Uh oh!

cvinh left a comment

Uh oh!

cvinh commented May 13, 2025 •

edited

Loading

Uh oh!

parvezqureshi commented May 15, 2025

Uh oh!

Uh oh!

Uh oh!

[17.0][ADD] Add pos_partner_birthdate_warning module #1338

[17.0][ADD] Add pos_partner_birthdate_warning module #1338

Uh oh!

Conversation

parvezqureshi commented Mar 19, 2025

Uh oh!

cvinh left a comment

Choose a reason for hiding this comment

Uh oh!

parvezqureshi commented Mar 19, 2025

Uh oh!

cvinh commented May 13, 2025

Uh oh!

parvezqureshi commented May 13, 2025

Uh oh!

cvinh left a comment

Choose a reason for hiding this comment

Uh oh!

cvinh commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parvezqureshi commented May 15, 2025

Uh oh!

Uh oh!

cvinh commented May 13, 2025 •

edited

Loading