Skip to content

[18.0][MIG] pos_remove_pos_category #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: 18.0
Choose a base branch
from

Conversation

thibaultrey
Copy link

Migration to 18.0

sylvainc and others added 30 commits March 31, 2025 19:36
./pos_remove_pos_category/product.py:55:1: W293 blank line contains whitespace

./pos_remove_pos_category/product.py:60:20: F821 undefined name 'tools'
image_medium with inverse parameter
updated method _save_image_medium
in inverse _save_image_medium method

- add class css and size 100px image in product category form view
This file replace src attribute original script POS
*Override javascript method original POS (get_image_url)
* migrate to v9 and add italian translation

* short headers

* migrate JS

* [fix] be defensive: do not assume we have a product category
@thibaultrey thibaultrey force-pushed the 18.0-mig-pos_remove_pos_category branch from 47b1d6e to 1093b3d Compare April 2, 2025 09:22
@thibaultrey thibaultrey force-pushed the 18.0-mig-pos_remove_pos_category branch from 1093b3d to ccdf727 Compare April 2, 2025 09:27
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for porting this module.
I think that this module should be simplified. This hard change catég -> pos categ is quite intrusive.

With some hook in the load of pos, we could load link product to categ.
What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.