[16.0][IMP]pos_order_to_sale_order: Allow add the commitment date.

[adasatorres]

This add-on allows you to add the commitment date to orders.
I've included a reference to the previous PR to maintain continuity of the discussion #1360 .

[OCA-git-bot]

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

[rrebollo]

Great job! The code looks good to me (LGTM). Thanks a lot for your contribution! 🙌
Just one thought: I see quite a bit of code around timezone handling (if I'm not mistaken). Do you think context_timestamp could already cover your needs, at least on the Python side?

[legalsylvain]

Thanks a lot ! Looks more simple.

One question : finally, don't see clearly the interest of the new setting "iface_sale_order_allow_commitment_date".

i mean, this field is optional, so it's possible for the use to enter the date, or let empty. don't you think ?

[Christian-RB]

The concern seems to be that the view could become too crowded in the future, so IMO keeping this as an option is more flexible for the users

[legalsylvain]

The concern seems to be that the view could become too crowded in the future, so IMO keeping this as an option is more flexible for the users

OK.

I guess it's ready to be merged, as soon as the date problem is fixed.