Skip to content

[17.0][ADD] pos_order_line_customer_history #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
parvezqureshi wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][ADD] pos_order_line_customer_history #1369

parvezqureshi wants to merge 1 commit into from

Conversation

@parvezqureshi
Copy link

@parvezqureshi parvezqureshi commented Apr 22, 2025

No description provided.

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch 2 times, most recently from 2106e1d to 0ce9710 Compare April 24, 2025 11:11
vehi-invitu
vehi-invitu approved these changes May 10, 2025
View reviewed changes
Copy link

@vehi-invitu vehi-invitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

cvinh
cvinh suggested changes May 23, 2025
View reviewed changes
Copy link
Contributor

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total and Discount column labels need to be swapped
Otherwise LGTM

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch from 0ce9710 to dc79c46 Compare May 23, 2025 05:19
@parvezqureshi
Copy link
Author

parvezqureshi commented May 23, 2025

The total and Discount column labels need to be swapped. Otherwise, LGTM

-> swapped.

cvinh
cvinh approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@cvinh cvinh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cvinh
cvinh reviewed May 23, 2025
View reviewed changes
pos_order_line_customer_history/static/src/Screens/CustomerHistoryScreen.xml Outdated
<div><t t-esc="getTotal(line)" /></div>
</div>
<div class="col wide p-2 ">
<div><t t-esc="line.discount" /></div>
Copy link
Contributor

@cvinh cvinh May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div><t t-esc="line.discount" /></div>
<div><t t-esc="line.discount" /> %</div>

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch from dc79c46 to 254d3b4 Compare May 23, 2025 09:59
@paku1036
Copy link

paku1036 commented Jun 7, 2025

LGTM

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch from 254d3b4 to 23c6da0 Compare July 8, 2025 11:26
@cvinh
Copy link
Contributor

cvinh commented Sep 8, 2025

LGTM

@paku1036 please review the PR with the review function of github
Go to "Files changed" and you will see the green review button at top right

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch from 23c6da0 to 65e7190 Compare September 9, 2025 08:00
paku1036
paku1036 approved these changes Sep 9, 2025
View reviewed changes
Copy link

@paku1036 paku1036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cvinh
cvinh suggested changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @legalsylvain we can put the module in development_status = alpha to be merged faster
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/oca_module_lifecycle_development_status.rst

pos_order_line_customer_history/__manifest__.py
"author": "Serpent Consulting Services Pvt. Ltd., Odoo Community Association (OCA)",
"maintainers": ["Serpent Consulting Services Pvt. Ltd."],
"license": "AGPL-3",
"installable": True,
Copy link
Contributor

@cvinh cvinh Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"installable": True,
"installable": True,
"development_status": "alpha",

@cvinh cvinh mentioned this pull request Sep 22, 2025
Open
@flotho
Copy link
Member

flotho commented Jan 11, 2026

Hi,
Is it possible to rebase to trigger CI/CD ?

Regards

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch from 65e7190 to a261170 Compare January 12, 2026 05:36
@parvezqureshi
Copy link
Author

parvezqureshi commented Jan 12, 2026

Hi, Is it possible to rebase to trigger CI/CD ?

Rebased.

@cvinh
Copy link
Contributor

cvinh commented Jan 12, 2026

Hi, Is it possible to rebase to trigger CI/CD ?

Rebased.

Thanks @parvezqureshi one more detail, can you add the alpha status in manifest please ? @legalsylvain will merge it afterwards

@parvezqureshi parvezqureshi force-pushed the 17.0-add-pos_order_line_customer_history branch from a261170 to 75abf1b Compare January 12, 2026 11:41
@parvezqureshi
Copy link
Author

parvezqureshi commented Jan 12, 2026

Hi, Is it possible to rebase to trigger CI/CD ?

Rebased.

Thanks @parvezqureshi one more detail, can you add the alpha status in manifest please ? @legalsylvain will merge it afterwards

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@cvinh cvinh cvinh approved these changes

@paku1036 paku1036 paku1036 approved these changes

@vehi-invitu vehi-invitu vehi-invitu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@parvezqureshi @paku1036 @cvinh @flotho @vehi-invitu @OCA-git-bot