Skip to content

[17.0][MIG] pos_sale_order_print #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: 17.0
Choose a base branch
from

Conversation

edescalona
Copy link

@BinhexTeam

Standard migration to 17.

@edescalona edescalona force-pushed the 17.0-mig-pos_sale_order_print branch from c9f4387 to 75617a4 Compare May 13, 2025 18:48
@edescalona edescalona force-pushed the 17.0-mig-pos_sale_order_print branch from 75617a4 to ff7d84a Compare May 13, 2025 18:53
@edescalona edescalona marked this pull request as ready for review May 13, 2025 18:57
@edescalona
Copy link
Author

Ready for review

Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edescalona Couldn't find any example where the text is fully in caps PRINT in the pos, can you change it to Print?

[17.0][IMP] pos_sale_order_print: Change name button.
@edescalona edescalona force-pushed the 17.0-mig-pos_sale_order_print branch from ff7d84a to bb8f814 Compare May 14, 2025 13:07
@edescalona edescalona requested a review from Christian-RB May 14, 2025 13:08
@edescalona
Copy link
Author

@Christian-RB Ready for review

@edescalona edescalona mentioned this pull request May 15, 2025
31 tasks
@adasatorres
Copy link
Contributor

Good morning, @edescalona

Why not introduce the functionality in the same way as the addon in version 16.0?

@edescalona
Copy link
Author

Hi @adasatorres , the reason was the way the popup is created in the new version and the new options are added. If you have a better way, please let me know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants