Skip to content

Conversation

@edescalona
Copy link

@BinhexTeam

Standard migration to 17.

@edescalona edescalona marked this pull request as ready for review May 20, 2025 13:15
@edescalona
Copy link
Author

Ready for review

Copy link

@adasatorres adasatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivs-cetmix
Copy link
Member

Hey @binhexsystems , any chance to get another review from you or some of your partners?

@ivs-cetmix
Copy link
Member

Hey @binhexsystems , any chance to get another review from you or some of your partners?

cc @BinhexTeam

Copy link

@arielbarreiros96 arielbarreiros96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edescalona Overall looks good, however while functional testing I noticed the UI looks a bit broken. This is how it used to look in v16
Captura de pantalla 2025-09-08 a las 22 02 28
and this is how it looks now
Captura de pantalla 2025-09-08 a las 22 02 45
This was with 3 locations, I assume with more locations will be even harder to understand availability at first glance

@edescalona
Copy link
Author

Hi @arielbarreiros96 , thanks for your comments, I'll check that visual detail.

@edescalona edescalona force-pushed the 17.0-mig-pos_stock_available_online branch from 4224e17 to 0606454 Compare September 8, 2025 21:59
@edescalona
Copy link
Author

Hi @ws, I've already fixed the visual, so it should look like this.

image

Thanks for your comments

Copy link

@arielbarreiros96 arielbarreiros96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After latest changes, LGTM

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 11, 2026
@ivs-cetmix ivs-cetmix removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 11, 2026
@ivs-cetmix
Copy link
Member

Hey @edescalona thank you for your contribution! @binhexsystems @jelenapoblet would be nice if you could finalize this PR so we could have it merged.

Copy link

@jelenapoblet jelenapoblet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to add a few additional tests. The code has already been reviewed, and I’ve also completed a functional review. @edescalona

@ivs-cetmix
Copy link
Member

I think we just need to add a few additional tests. The code has already been reviewed, and I’ve also completed a functional review. @edescalona

@jelenapoblet thank you! @edescalona could you please rebase the branch and improve the test coverage if codecove tests are still red after the rebase?

@edescalona edescalona force-pushed the 17.0-mig-pos_stock_available_online branch from 0606454 to 58880aa Compare January 12, 2026 19:46
@edescalona
Copy link
Author

Hi @ivs-cetmix , the rebase has been performed and the tests are correct.

@ivs-cetmix
Copy link
Member

@edescalona thank you!
Could you please squash the bot commits as well? Not mandatory however would help to make the history cleaner. Let me know if you can't.
image

@edescalona
Copy link
Author

Okay @ivs-cetmix , I'll check it now and let you know.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain and others added 15 commits January 12, 2026 15:26
Currently translated at 100.0% (16 of 16 strings)

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/es/
Currently translated at 100.0% (16 of 16 strings)

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/es/
Make stock updates not only on quant updates, but also when a stock
move changes its state.

This fixes two bugs:

- Stock is not updated when a new incoming move is ready, or when a
  ready one is cancelled

- Stock is decreased twice because when quant is updated, move is
  taken in account because it is not yet on 'done' state
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/
When notification is triggered by a `stock.move`, it has to use
warehouses related to its locations instead of direct linked
warehouse.
Currently translated at 100.0% (18 of 18 strings)

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/it/
…house_id) of pos.config() have the same label: Warehouse. [Modules: pos_stock_available_online and point_of_sale]
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/
…rite on many items. (for exemple many quants)
Currently translated at 100.0% (19 of 19 strings)

Translation: pos-16.0/pos-16.0-pos_stock_available_online
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/it/
# Conflicts:
#	pos_stock_available_online/__manifest__.py
@edescalona edescalona force-pushed the 17.0-mig-pos_stock_available_online branch from 58880aa to 033ccad Compare January 12, 2026 20:29
@edescalona
Copy link
Author

Hi @ivs-cetmix , I've already removed the bot commits. If everything looks correct, then it's ready to merge. Thanks.

@ivs-cetmix
Copy link
Member

@edescalona looks good, thank you for your contribution!
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1385-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cfc6930 into OCA:17.0 Jan 12, 2026
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c322c37. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.