-
-
Notifications
You must be signed in to change notification settings - Fork 670
[17.0][MIG] pos_stock_available_online #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] pos_stock_available_online #1385
Conversation
|
Ready for review |
adasatorres
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hey @binhexsystems , any chance to get another review from you or some of your partners? |
cc @BinhexTeam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edescalona Overall looks good, however while functional testing I noticed the UI looks a bit broken. This is how it used to look in v16

and this is how it looks now

This was with 3 locations, I assume with more locations will be even harder to understand availability at first glance
|
Hi @arielbarreiros96 , thanks for your comments, I'll check that visual detail. |
4224e17 to
0606454
Compare
|
Hi @ws, I've already fixed the visual, so it should look like this.
Thanks for your comments |
arielbarreiros96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After latest changes, LGTM
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
Hey @edescalona thank you for your contribution! @binhexsystems @jelenapoblet would be nice if you could finalize this PR so we could have it merged. |
jelenapoblet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to add a few additional tests. The code has already been reviewed, and I’ve also completed a functional review. @edescalona
@jelenapoblet thank you! @edescalona could you please rebase the branch and improve the test coverage if codecove tests are still red after the rebase? |
…lability with POS [FIX] fixed pre-commit errors
Currently translated at 100.0% (16 of 16 strings) Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/it/
Currently translated at 100.0% (16 of 16 strings) Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/
Remove Cetmix from maintainers
0606454 to
58880aa
Compare
|
Hi @ivs-cetmix , the rebase has been performed and the tests are correct. |
|
@edescalona thank you! |
|
Okay @ivs-cetmix , I'll check it now and let you know. |
|
This PR has the |
Currently translated at 100.0% (16 of 16 strings) Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/es/
Currently translated at 100.0% (16 of 16 strings) Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/es/
Make stock updates not only on quant updates, but also when a stock move changes its state. This fixes two bugs: - Stock is not updated when a new incoming move is ready, or when a ready one is cancelled - Stock is decreased twice because when quant is updated, move is taken in account because it is not yet on 'done' state
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/
When notification is triggered by a `stock.move`, it has to use warehouses related to its locations instead of direct linked warehouse.
Currently translated at 100.0% (18 of 18 strings) Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/it/
…house_id) of pos.config() have the same label: Warehouse. [Modules: pos_stock_available_online and point_of_sale]
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/
…rite on many items. (for exemple many quants)
Currently translated at 100.0% (19 of 19 strings) Translation: pos-16.0/pos-16.0-pos_stock_available_online Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_stock_available_online/it/
# Conflicts: # pos_stock_available_online/__manifest__.py
58880aa to
033ccad
Compare
|
Hi @ivs-cetmix , I've already removed the bot commits. If everything looks correct, then it's ready to merge. Thanks. |
|
@edescalona looks good, thank you for your contribution! |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c322c37. Thanks a lot for contributing to OCA. ❤️ |


@BinhexTeam
Standard migration to 17.