[17.0][MIG] pos_receipt_hide_price #1393
Conversation
|
Ready for review |
adasatorres
left a comment
adasatorres
left a comment
There was a problem hiding this comment.
Good morning, it is not necessary to add this functionality to the order lines; the information should only be hidden in the receipt template.
This happens as soon as the module is installed. If you uninstall it, the price is shown again.
edescalona
force-pushed
the
17.0-mig-pos_receipt_hide_price
branch
from
678d48d to
0d6917a
Compare
|
Hi @adasatorres, ready for review. |
christian-ramos-tecnativa
force-pushed
the
17.0-mig-pos_receipt_hide_price
branch
from
0d6917a to
d8e72f8
Compare
|
@edescalona It seems like when the ticket is directly sent to the printer is displaying the prices no matter what. I assume we have to extend also the function |
|
Hi @Christian-RB , I assume you're referring to automatically printing the receipt? |
Yes, when the receipt is directly sent to a printer |
|
Hi @Christian-RB , in that case it is not hidden because there is currently nothing that says hide the price, since it is hidden when you press the button on the screen after payment. So we should add another setting below the automatic receipt to hide the prices at that time as well, what do you think? |
|
Hi @Christian-RB , could you please review the changes and tell me what you think of the solution? If everything is OK, I'll proceed with correcting the commits. Thanks. |
|
@edescalona with this approach the user is not able to switch the feature dynamically, I suggest adding a button to the main order view to define if the prices should be hide at front for that specific order, this will also be useful for those user with the "skip printing view" option and direct print |
|
Hi @Christian-RB , I think it's a good idea, thanks for your comments. |
|
We are missing the new functionality in the reprint order view, could we add it @edescalona? |
|
Hi @Christian-RB ready for review. 
|
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
…utomatically generated receipt.
…roducts by multiple barcodes in search bar of POS.
Currently translated at 100.0% (5 of 5 strings) Translation: pos-14.0/pos-14.0-pos_product_multi_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_multi_barcode/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_product_multi_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_product_multi_barcode/
Currently translated at 100.0% (3 of 3 strings) Translation: pos-16.0/pos-16.0-pos_product_multi_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_product_multi_barcode/it/
Currently translated at 100.0% (3 of 3 strings) Translation: pos-16.0/pos-16.0-pos_product_multi_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_product_multi_barcode/es/
If a `barcode` is already in `product_by_barcode`, do not override it, as Odoo does with `product_by_id`. This can lead to incoherent data if something changes after product is first loaded and then reloads (if limited loading is enabled), or it is modified in `product_by_id` and not in `product_by_barcode`.
[DON'T MERGE] test-requirements.txt
edescalona
force-pushed
the
17.0-mig-pos_receipt_hide_price
branch
from
e0856cb to
c74262d
Compare
|
ping @christian-ramos-tecnativa @etobella @ ivantodorovich |
github-actions
bot
removed
the
stale
14 participants
@BinhexTeam