Skip to content

Conversation

@cvinh
Copy link
Contributor

@cvinh cvinh commented Dec 17, 2025

We could not backport #1462 because logic is not the same in v18

@cvinh cvinh force-pushed the 18.0-mig-pos_product_display_default_code branch 2 times, most recently from 026c687 to c921881 Compare December 17, 2025 02:38
@cvinh cvinh force-pushed the 18.0-mig-pos_product_display_default_code branch 9 times, most recently from 2cf9c17 to 4f3517d Compare December 17, 2025 06:54
@cvinh cvinh force-pushed the 18.0-mig-pos_product_display_default_code branch from 4f3517d to 723851b Compare December 17, 2025 07:00
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks,
successfully tested on runboat
LGTM

@flotho
Copy link
Member

flotho commented Jan 10, 2026

ping @DorianMAG @JulienMartinez

Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thx for this work.
Code review
Functional test
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants