Skip to content

[17.0] [MIG] product_pricelist_simulation: Migration to 17.0#1653

Merged
OCA-git-bot merged 31 commits intoOCA:17.0from
BizzAppDev-Systems:17.0-mig-product_pricelist_simulation-BAD
Jan 23, 2025
Merged

[17.0] [MIG] product_pricelist_simulation: Migration to 17.0#1653
OCA-git-bot merged 31 commits intoOCA:17.0from
BizzAppDev-Systems:17.0-mig-product_pricelist_simulation-BAD

Conversation

@bizzappdev
Copy link
Contributor

No description provided.

Ernesto Tejeda and others added 30 commits May 31, 2024 10:56
Co-authored-by: Sylvain LE GAL <sylvain.legal@grap.coop>
Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/es/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/pt_BR/
SavepointCase is deprecated and it was making CI fail.
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/it/
It reduces the confusion specially when changing the qty to a value
greater than 1.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/it/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/pt_BR/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/es/
Monetary fields do not have any digits attribute
since their precision comes from the currency.

There's also no need to specify a currency field
when currency_id is available on the model.
Currently translated at 100.0% (22 of 22 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_simulation
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_simulation/tr/
@bizzappdev bizzappdev marked this pull request as ready for review June 14, 2024 05:40
@pedrobaeza
Copy link
Member

/ocabot migration product_pricelist_simulation

Comment on lines +89 to 91
self.assertAlmostEqual(wizard_form.line_ids._records[0]["price"], 80.0)
self.assertAlmostEqual(wizard_form.line_ids._records[1]["price"], 50.0)
# # Template 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this changes ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting order for the pricelist has been changed in Odoo
v16: https://github.com/odoo/odoo/blob/16.0/addons/product/models/product_pricelist.py#L12
v17: https://github.com/odoo/odoo/blob/17.0/addons/product/models/product_pricelist.py#L13
which causes the order of wizard lines to be sorted.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 14, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2024
69 tasks
@@ -0,0 +1,2 @@
"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
"access_wizard_preview_pricelist","access.wizard.preview.pricelist","model_wizard_preview_pricelist","base.group_system",1,1,1,0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check security for model wizard.preview.pricelist.line

@github-actions
Copy link

github-actions bot commented Jan 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 5, 2025
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 19, 2025
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1653-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 701f430 into OCA:17.0 Jan 23, 2025
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 81761d2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.