[17.0][MIG] product_packaging_level_salable: Migration to 17.0#1669
Conversation
Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level_salable Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level_salable/it/
Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level_salable Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level_salable/es/
trisdoan
left a comment
trisdoan
left a comment
There was a problem hiding this comment.
You need to remove migration script as well
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
bizzappdev
force-pushed
the
17.0-mig-product_packaging_level_salable-BAD
branch
from
401cb4a to
8d7471d
Compare
Removed. Thanks for noticing. |
| onchange_res = self.order_line._onchange_product_packaging_id() | ||
| self.assertIn("warning", onchange_res) |
There was a problem hiding this comment.
These lines are never tested because of the ValidationError just above.
Could you move this to a separate test method?
|
|
||
| def test_packaging_level_can_be_sold(self): | ||
| self.order_line.write({"product_packaging_id": self.packaging_tu.id}) | ||
| with self.assertRaises(ValidationError): |
There was a problem hiding this comment.
nitpicking: use self.assertRaisesRegex and compare the actual error message
bizzappdev
force-pushed
the
17.0-mig-product_packaging_level_salable-BAD
branch
from
8d7471d to
1b35425
Compare
|
@ivantodorovich, changes are done. |
|
/ocabot migration product_packaging_level_salable |
sebalix
left a comment
sebalix
left a comment
There was a problem hiding this comment.
LG, can you remove the [DON'T MERGE] commit now that the dependency is merged? Thanks!
bizzappdev
force-pushed
the
17.0-mig-product_packaging_level_salable-BAD
branch
from
1b35425 to
9e7af88
Compare
|
@sebalix test-requirement commit has been removed. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2d1704a. Thanks a lot for contributing to OCA. ❤️ |
sebalix
changed the title
8 participants
Dependency MR for module
product_packaging_level#1662