[17.0][MIG] product_code_mandatory#1697
Merged
OCA-git-bot merged 36 commits intoOCA:17.0from Aug 2, 2024
Merged
Conversation
* [ADD] Module to set the internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
Move setUp test class to setUpClass for better performant [ADD] product_code_mandatory: Add contributors [IMP] product_cost_security: clarify product cost edit required permissions As seen in OCA/margin-analysis#198 (review), a user needs some other group that grants them permissions for editing products, apart from this one that allows them to edit product cost. This might not seem obvious to the user, so it's better to document it. Btw, I renamed the groups to be shorter. Still easy to understand, now that groups are grouped (🥁). @moduon MT-5158 [UPD] Update product_cost_security.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_cost_security Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_cost_security/
ced-adhoc
force-pushed
the
17.0-mig-product_code_mandatory
branch
2 times, most recently
from
9c97ab6 to
c5fb225
Compare
ced-adhoc
force-pushed
the
17.0-mig-product_code_mandatory
branch
from
c5fb225 to
29b61df
Compare
florenciafrigieri2
approved these changes
Jul 31, 2024
florenciafrigieri2
left a comment
florenciafrigieri2
left a comment
There was a problem hiding this comment.
Functional review, working ok. It adds an internal reference to products and variants when they're empty.
|
@pedrobaeza Hi Pedro! What do you think about this pr? I think we can merge it. |
rov-adhoc
approved these changes
Aug 2, 2024
pedrobaeza
approved these changes
Aug 2, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
/ocabot migration product_code_mandatory
/ocabot merge nobump
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at cafbc95. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on migration PR to v16: #1693