[17.0][MIG] product_profile by bosd · Pull Request #1731 · OCA/product-attribute

bosd · 2024-09-30T12:12:02Z

No description provided.

bosd · 2024-09-30T12:12:30Z

@sbidoul, @rousseldenis Can you please review this one as well.

yvaucher · 2024-09-30T12:31:51Z

/ocabot migration product_profile

yvaucher

Can you restore the previous indents of the xml file? IMO, current state makes it less readable.

product_profile/views/config_view.xml

yvaucher · 2024-09-30T12:40:40Z

product_profile/views/config_view.xml

-                <div class="col-12 col-lg-6 o_setting_box">
-                    <div class="o_setting_left_pane">
+            <xpath expr="//block[@name='catalog_setting_container']" position="inside">
+                    <setting>


This seems over indented, not blocking for this though.

Dranyel-Bosd

LGTM 💯

patrickrwilson · 2025-01-07T18:11:42Z

When we were looking at this and extending it with our custom module to add product fields, we found that this if statement inside the product_profile.py should be after super for it to properly update the products...

bosd · 2025-01-18T12:34:23Z

@patrickrwilson Thanks for the feedback.
But I think your suggestion actually bypasses the refresh_product_vals.
Likely there is still a small bug in the refactoring of the code to the new V17 orm capabilities (_read_group).
The pre V17 versions of this module where flooding the orm with searches.

Actually this code has no test/coverage. I started to work on the tester / example module.
V16 PR here: #1850

bealdav · 2025-04-15T08:03:48Z

Hi @bosd, thanks for your contribution here.
Do you plan to go on this PR ?

bosd · 2025-04-15T08:05:46Z

We are currently not using it. So feel free to take-over /contribute.

github-actions · 2025-08-17T12:22:57Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

bosd · 2025-10-29T12:08:30Z

I think after one year and a month, this PR has been "marinated" enough 😄
Let's go? 🚀

yvaucher · 2025-12-05T07:19:44Z

/ocabot merge nobump

OCA-git-bot · 2025-12-05T07:19:52Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1731-by-yvaucher-bump-nobump, awaiting test results.

Signed-off-by yvaucher

OCA-git-bot · 2025-12-05T07:28:21Z

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1731-by-yvaucher-bump-nobump, awaiting test results.

Signed-off-by yvaucher

OCA-git-bot · 2025-12-05T07:36:38Z

@yvaucher The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name product-attribute --branch 17.0 --addons-dir /tmp/tmpjf8dxgcu --commit failed with output:

/tmp/tmpjf8dxgcu/product_profile/README.rst:124: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 7, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1462, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1383, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1246, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 814, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 465, in publish_file
    output, _publisher = publish_programmatically(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 794, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 269, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 95, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 101, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 185, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 182, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 234, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 446, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2487, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2499, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2215, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 2063, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 256, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 217, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpjf8dxgcu/product_profile/README.rst:124: (ERROR/3) Duplicate substitution definition name: "image1".

yvaucher · 2025-12-10T11:04:48Z

@bosd This most likely needs a rebase

StefanRijnhart · 2025-12-24T21:27:56Z

I've migrated this to 18.0 in #2173 and I fixed the duplicate image1 error with

Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_profile/ca/

Give the possibility to call directly with a domain the method _customize_view with a domain so you can reuse this method in custom module to add profile filter. In my case I want to add a filter on mrp.bom so just adding a related field + a call to _customize_view allow to add only profile related to manufacturing Also add a separator to avoid mixing profile filter with existing filter

Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/it/

Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/nl_NL/

Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/it/

Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch" Fixup! Update product_profile

Update product_profile.py refactor for V17 way [IMP] product_profile: pre-commit execution Fixup product_profile.py

StefanRijnhart

/ocabot merge nobump

OCA-git-bot · 2026-01-24T11:41:32Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1731-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2026-01-24T11:50:01Z

Congratulations, your PR was merged at a626c83. Thanks a lot for contributing to OCA. ❤️

bosd force-pushed the 17.0-mig-product_profile branch from 0eddb6b to 8f105a8 Compare September 30, 2024 12:17

bosd mentioned this pull request Sep 30, 2024

Migration to version 17.0 #1446

Open

69 tasks

OCA-git-bot added this to the 17.0 milestone Sep 30, 2024

yvaucher reviewed Sep 30, 2024

View reviewed changes

bosd force-pushed the 17.0-mig-product_profile branch from 8f105a8 to c3deb6e Compare September 30, 2024 13:19

bosd requested a review from yvaucher October 10, 2024 20:41

Dranyel-Bosd approved these changes Oct 10, 2024

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 17, 2025

yvaucher approved these changes Aug 18, 2025

View reviewed changes

OCA-git-bot added the approved label Aug 18, 2025

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 24, 2025

OCA-git-bot added a commit that referenced this pull request Dec 5, 2025

Merge PR #1731 into 17.0

f51de58

Signed-off-by yvaucher

OCA-git-bot added the bot is merging ⏳ label Dec 5, 2025

OCA-git-bot added a commit that referenced this pull request Dec 5, 2025

Merge PR #1731 into 17.0

d7d9486

Signed-off-by yvaucher

OCA-git-bot removed the bot is merging ⏳ label Dec 5, 2025

StefanRijnhart mentioned this pull request Dec 24, 2025

[18.0][MIG] product_profile: Migration to 18.0 #2173

Merged

sebastienbeau and others added 21 commits January 24, 2026 12:32

[IMP] product_profile: black, isort, prettier

77144af

[MIG] product_profile: Migration to 14.0

0849939

[FIX] add missing default value

683c650

[FIX] fix modifier, inherit _fields_view_get to avoid complexe code

b56df42

[UPD] Update product_profile.pot

bda6404

[UPD] README.rst

27e7628

[IMP] update dotfiles [ci skip]

6814dfd

product_profile 14.0.1.0.1

065a56c

[MIG] product_profile: Migration to 15.0

5899543

product_profile: add demo data

39efc36

[UPD] Update product_profile.pot

9b00f22

[UPD] README.rst

58b1ff3

[MIG] product_profile: Migration to 16.0

d5dcf69

[IMP]Product_profile: Support Create multi

190b963

Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch" Fixup! Update product_profile

[IMP] product_profile: pre-commit execution

4b35459

[MIG] product_profile: Migration to 17.0

8a63512

Update product_profile.py refactor for V17 way [IMP] product_profile: pre-commit execution Fixup product_profile.py

bosd force-pushed the 17.0-mig-product_profile branch from c3deb6e to 8a63512 Compare January 24, 2026 11:34

StefanRijnhart approved these changes Jan 24, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 24, 2026

OCA-git-bot merged commit 137fc14 into OCA:17.0 Jan 24, 2026
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 24, 2026

bosd deleted the 17.0-mig-product_profile branch January 24, 2026 11:55

Uh oh!

Conversation

bosd commented Sep 30, 2024

Uh oh!

bosd commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yvaucher commented Sep 30, 2024

Uh oh!

yvaucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yvaucher Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

Dranyel-Bosd left a comment

Choose a reason for hiding this comment

Uh oh!

patrickrwilson commented Jan 7, 2025

Uh oh!

bosd commented Jan 18, 2025

Uh oh!

bealdav commented Apr 15, 2025

Uh oh!

bosd commented Apr 15, 2025

Uh oh!

github-actions bot commented Aug 17, 2025

Uh oh!

bosd commented Oct 29, 2025

Uh oh!

yvaucher commented Dec 5, 2025

Uh oh!

OCA-git-bot commented Dec 5, 2025

Uh oh!

OCA-git-bot commented Dec 5, 2025

Uh oh!

OCA-git-bot commented Dec 5, 2025

Uh oh!

yvaucher commented Dec 10, 2025

Uh oh!

StefanRijnhart commented Dec 24, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 24, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

bosd commented Sep 30, 2024 •

edited

Loading