[18.0][IMP] product_secondary_unit: add configuration for report presentation by AungKoKoLin1997 · Pull Request #2211 · OCA/product-attribute

AungKoKoLin1997 · 2026-02-16T03:36:03Z

Add hidden security groups (group_sale_secondary_unit, group_purchase_secondary_unit) and company-level configuration fields for secondary unit price display and column visibility.

These groups and settings are defined here in the base module so they can be shared across Sale, Purchase, and Invoicing without forcing account_move_secondary_unit to depend on sale_order_secondary_unit or purchase_order_secondary_unit.

Each child module activates the relevant group(s) via implied_ids on install, which controls the visibility of the corresponding settings in the UI.

@qrtl QT6210

OCA-git-bot · 2026-02-16T04:34:30Z

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

yostashiro

Code review. LGTM.

… unmerged dependency Partially revert a1eea87 for purchase order and quotation report templates. The reverted portions rely on methods (hide_secondary_uom_column, get_secondary_uom_display_mode) introduced by OCA/product-attribute#2211, which is not yet merged. Without that dependency, the reports would crash when printing. The secondary quantity column is kept but the conditional visibility and display mode logic are removed until the dependency is available.

pedrobaeza · 2026-02-16T15:10:08Z

product_secondary_unit/models/res_company.py

+class ResCompany(models.Model):
+    _inherit = "res.company"
+
+    secondary_uom_price_display_sale = fields.Selection(


This configurability level seems a bit insane. Are you going to display UoM price on sale, but not on purchase, but show the UoM? Can't this be fit with a single security group "Show seconday unit prices"?

For showing the UoM column option, it is intended only to preserve the existing Sales/Purchase report behavior of sale_order_secondary_unit and purchase_order_secondary_unit when Primary Unit Price Only is selected. For the other price display modes, the secondary UoM is already shown in the quantity and price columns, so showing an additional UoM column would be redundant.

I don't think Sales and Purchase should always share the same display style for the secondary unit price and the secondary unit column. Therefore, I prefer separate settings for Sales and Purchase documents, with separate security groups to control each document type.

This is the expected report when Primary Unit Price Only is selected without hiding the UoM column.

This is the expected report when Prioritize Secondary Unit Price is selected.

This is the expected report when Both Primary and Secondary Unit Prices is selected.

But as said, this is too many configurations, while it's not a usual problem to show both. This only increases the maintenance burden to the main module being a residual feature that most people won't use, being enough with the default option. I think this has to be simplified.

@pedrobaeza To me it makes sense to be able to configure sales and purchasing separately as they have different needs. But we can do the secondary UoM price display thing in a separate module if it's too much to be covered in the main module, which will mean four new additional modules (i.e., product_secondary_unit_price, purchase_order_secondary_unit_price, sale_order_secondary_unit_price and account_move_secondary_unit_price).

What we still want to do in this module, though, is to be able to hide the secondary qty column in reports. For this, we don't need to have separate config for sales and purchasing (as we will most likely disable this for both anyway).

Does this sound like a good approach?

I also came across this need: to choose if the secondary unit should be visible on sales document or purchase documents.
It can be the case that the feature helps pick quantities on order lines, but we don't want/need them on the PDFs.
And the decision can be different for sale or purchase.

@AungKoKoLin1997 That's a feature change and should go in a separate commit, so that it can be backported. Thanks.

@dreispt For easier backporting, I’ll split this into two commits:

Commit 1: Hide column configuration (hide_secondary_uom_column_* fields + related logic)

Commit 2: Price display configuration (secondary_uom_price_display_* fields + related logic)

@dreispt I split into two commits.

@sergio-teruel is the main creator of this module, so I let him to decide at last if he considers OK to have all the configuration tweaks in the main module.

@sergio-teruel Can you please review the changes in this PR? We’re planning to use this module for our customer and would like to proceed. If you think the current changes aren’t suitable, I can follow up based on @yostashiro suggestion above.

kanda999

Confirmed that the report display changes depending on the option settings in my local

nobuQuartile

Functional review LGTM:
Check the report behaviour with the related purchase_order_secondary_unit PR code.

… unmerged dependency Partially revert a1eea87 for purchase order and quotation report templates. The reverted portions rely on methods (hide_secondary_uom_column, get_secondary_uom_display_mode) introduced by OCA/product-attribute#2211, which is not yet merged. Without that dependency, the reports would crash when printing. The secondary quantity column is kept but the conditional visibility and display mode logic are removed until the dependency is available.

Add hidden security groups (group_sale_secondary_unit, group_purchase_secondary_unit) and company-level configuration fields to control the visibility of the "Second Qty" column in reports. These groups and settings are defined here in the base module so they can be shared across Sale, Purchase, and Invoicing without forcing account_move_secondary_unit to depend on sale_order_secondary_unit or purchase_order_secondary_unit. Each child module activates the relevant group(s) via implied_ids on install, which controls the visibility of the corresponding settings in the UI. Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>

Add company-level configuration fields for secondary unit price display. This allows configuring how unit prices and quantities are shown in reports when secondary units are used. The price display can be configured to show: - Primary unit price only (default) - Secondary unit price (prioritized) - Both primary and secondary unit prices This builds on the hide column configuration to provide flexible report presentation options. Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>

AungKoKoLin1997 force-pushed the 18.0-imp-report_configuration_product_secondary_unit branch from 211015e to b59ecd9 Compare February 16, 2026 03:38

yostashiro mentioned this pull request Feb 16, 2026

[18.0][IMP] purchase_order_secondary_unit: add vendor pricelist support OCA/purchase-workflow#2932

Merged

yostashiro force-pushed the 18.0-imp-report_configuration_product_secondary_unit branch from b59ecd9 to b569a94 Compare February 16, 2026 12:29

yostashiro approved these changes Feb 16, 2026

View reviewed changes

This was referenced Feb 16, 2026

[18.0][FIX] purchase_order_secondary_unit: revert report features requiring unmerged dependency OCA/purchase-workflow#2953

Merged

Odoo 18.0: Error on purchase_order_secondary_unit.report_purchaseorder_document OCA/purchase-workflow#2951

Open

pedrobaeza added this to the 18.0 milestone Feb 16, 2026

pedrobaeza reviewed Feb 16, 2026

View reviewed changes

kanda999 approved these changes Feb 18, 2026

View reviewed changes

OCA-git-bot added the approved label Feb 18, 2026

nobuQuartile approved these changes Feb 19, 2026

View reviewed changes

This was referenced Feb 26, 2026

[19.0][MIG]: product_secondary_unit #2222

Open

[19.0][MIG]: sale_order_secondary_unit OCA/sale-workflow#4175

Open

JochenDeBie mentioned this pull request Feb 26, 2026

[19.0][MIG]: purchase_order_secondary_unit OCA/purchase-workflow#2968

Open

AungKoKoLin1997 force-pushed the 18.0-imp-report_configuration_product_secondary_unit branch 2 times, most recently from fa61d03 to eef5439 Compare March 3, 2026 02:35

AungKoKoLin1997 force-pushed the 18.0-imp-report_configuration_product_secondary_unit branch 3 times, most recently from fcaf7e9 to 23d9e96 Compare March 3, 2026 03:07

AungKoKoLin1997 force-pushed the 18.0-imp-report_configuration_product_secondary_unit branch from 23d9e96 to 96fdd1a Compare March 3, 2026 03:10

AungKoKoLin1997 requested a review from dreispt March 3, 2026 03:14

Uh oh!

Conversation

AungKoKoLin1997 commented Feb 16, 2026

Uh oh!

OCA-git-bot commented Feb 16, 2026

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

yostashiro Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

dreispt Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

dreispt Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kanda999 left a comment

Choose a reason for hiding this comment

Uh oh!

nobuQuartile left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AungKoKoLin1997 Feb 17, 2026 •

edited

Loading

AungKoKoLin1997 Mar 2, 2026 •

edited

Loading

AungKoKoLin1997 Mar 5, 2026 •

edited

Loading