Open
Conversation
SilvioC2C
force-pushed
the
19.0-mig-product_status
branch
3 times, most recently
from
ea01d80 to
01438c7
Compare
jcoux
reviewed
Feb 25, 2026
| group_product_state_manager = self.env.ref( | ||
| "product_state.group_product_state_manager" | ||
| ) | ||
| self.env.user.write({"group_ids": [(4, group_product_state_manager.id)]}) |
| st_env = self.env["product.state"] | ||
| demo_user = self.demo_user | ||
| demo_user.group_ids = [ | ||
| (4, self.env.ref("product_state.group_product_state_manager").id) |
Comment on lines
+3
to
+31
| <!-- prettier-ignore-start --> | ||
| <function name="write" model="ir.model.data"> | ||
| <function name="search" model="ir.model.data"> | ||
| <value eval="[('module', '=', 'product_state'), ('model', '=', 'product.state')]"/> | ||
| </function> | ||
| <value eval="{'noupdate': False}" /> | ||
| </function> | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| <record id="product_state.product_state_draft" model="product.state"> | ||
| <field name="active" eval="False" /> | ||
| </record> | ||
|
|
||
| <record id="product_state.product_state_end" model="product.state"> | ||
| <field name="active" eval="False" /> | ||
| </record> | ||
|
|
||
| <record id="product_state.product_state_obsolete" model="product.state"> | ||
| <field name="active" eval="False" /> | ||
| </record> | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| <function name="write" model="ir.model.data"> | ||
| <function name="search" model="ir.model.data"> | ||
| <value eval="[('module', '=', 'product_state'), ('model', '=', 'product.state')]"/> | ||
| </function> | ||
| <value eval="{'noupdate': True}" /> | ||
| </function> | ||
| <!-- prettier-ignore-end --> |
There was a problem hiding this comment.
I think you can use function to directly write active field on the 3 records, without changing noupdate flag.
Something like:
Suggested change
| <!-- prettier-ignore-start --> | |
| <function name="write" model="ir.model.data"> | |
| <function name="search" model="ir.model.data"> | |
| <value eval="[('module', '=', 'product_state'), ('model', '=', 'product.state')]"/> | |
| </function> | |
| <value eval="{'noupdate': False}" /> | |
| </function> | |
| <!-- prettier-ignore-end --> | |
| <record id="product_state.product_state_draft" model="product.state"> | |
| <field name="active" eval="False" /> | |
| </record> | |
| <record id="product_state.product_state_end" model="product.state"> | |
| <field name="active" eval="False" /> | |
| </record> | |
| <record id="product_state.product_state_obsolete" model="product.state"> | |
| <field name="active" eval="False" /> | |
| </record> | |
| <!-- prettier-ignore-start --> | |
| <function name="write" model="ir.model.data"> | |
| <function name="search" model="ir.model.data"> | |
| <value eval="[('module', '=', 'product_state'), ('model', '=', 'product.state')]"/> | |
| </function> | |
| <value eval="{'noupdate': True}" /> | |
| </function> | |
| <!-- prettier-ignore-end --> | |
| <function model="product.state" name="write"> | |
| <value eval="[ref('product_state.product_state_draft'), ref('product_state.product_state_end'), ref('product_state.product_state_obsolete')]"/> | |
| <value eval="{'active': False}"/> | |
| </function> |
Contributor
|
@SilvioC2C Plase, remove files of product_state module and add the [DON'T MERGE] commit. |
Before this change a product would never get back into its default state. Example: a new proudct with a new until date in the past will keep a state set as `new`. Instead it should be set to the default status.
yankinmax
force-pushed
the
19.0-mig-product_status
branch
from
01438c7 to
e7cd3b4
Compare
Contributor
|
Hello @jcoux @Reyes4711-S73 @vvrossem |
vvrossem
approved these changes
Mar 13, 2026
| inverse="_inverse_product_state_id", | ||
| default=lambda self: self.product_tmpl_id._get_default_product_state().id, | ||
| index=True, | ||
| tracking=10, |
Contributor
There was a problem hiding this comment.
I wonder why a Boolean was not used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2217, will be rebased once the other PR is merged