[18.0][IMP] product_pricelist_direct_print: Add support for grouping product template fields and m2m#2244
Open
CarlosRoca13 wants to merge 1 commit intoOCA:18.0from
Open
Conversation
Contributor
|
Hi @legalsylvain, |
Contributor
|
Hi @CarlosRoca13. Could you add a test ? (and take a look on red CI) ? thanks ! |
CarlosRoca13
force-pushed
the
18.0-FIX-product_pricelist_direct_print
branch
from
25fc270 to
d33c167
Compare
Contributor
Author
|
Done @legalsylvain |
…t template fields and m2m Before these changes, fields were always taken from the variant model, regardless of whether grouping by variants was selected or not, which could lead to errors. Additionally, grouping by many-to-many (m2m) fields was not allowed. With these changes, it is now possible to group by m2m fields, and products are distinguished from variants when retrieving their fields, ensuring that errors do not occur.
CarlosRoca13
force-pushed
the
18.0-FIX-product_pricelist_direct_print
branch
from
d33c167 to
068aa4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before these changes, fields were always taken from the variant model, regardless of whether grouping by variants was selected or not, which could lead to errors. Additionally, grouping by many-to-many (m2m) fields was not allowed.
With these changes, it is now possible to group by m2m fields, and products are distinguished from variants when retrieving their fields, ensuring that errors do not occur.
cc @Tecnativa TT61595
ping @sergio-teruel @carlosdauden