[15.0][MIG] purchase_triple_discount by ramiadavid · Pull Request #1437 · OCA/purchase-workflow

ramiadavid · 2022-04-26T17:47:43Z

ramiadavid · 2022-09-06T21:24:08Z

Can someone review this PR?

oca-clabot · 2022-10-02T15:40:40Z

Hey @ramiadavid, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

@ramiadavid (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

ao-landoo · 2022-10-04T11:36:16Z

@ramiadavid Can you add this commit please?
#1587

- remove dependency to obsolete module product_supplierinfo_discount - rename procurement.rule into stock.rule - Use new hook introduced in purchase_discount V12 to add discount2 and discount3 - Introduce discount2 and discount3 in purchase.report model

…unt, adding hook

* Lighter algorithm when synchronizing PO line info to product.supplierinfo. * Use new create multi method for performance. * Better SQL expresion in purchase report for decreasing the number of operations. * Add test for purchase report.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/

Currently translated at 100.0% (15 of 15 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/

Currently translated at 100.0% (15 of 15 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/it/

…upplierinfo form view

…s on purchase report (cherry picked from commit 6e5b652)

ramiadavid · 2022-10-05T19:54:46Z

@ao-landoo Done, but the report in v15 has changed, I had to modify it

ao-landoo

Technical approval

OCA-git-bot · 2022-10-06T07:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

manuelregidor

LGTM

HaraldPanten · 2022-10-10T15:11:11Z

Hi @rousseldenis @gurneyalex @JordiBForgeFlow could you merge this one?

bi-landoo · 2022-10-11T12:15:00Z

Hi @rousseldenis @gurneyalex @JordiBForgeFlow @pedrobaeza could you please merge it?

Thanks!

pedrobaeza · 2022-10-11T12:16:57Z

Hello from OCA days!

/ocabot migration purchase_triple_discount
/ocabot merge nobump

OCA-git-bot · 2022-10-11T12:17:21Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1437-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-10-11T12:25:09Z

Congratulations, your PR was merged at 329cbcc. Thanks a lot for contributing to OCA. ❤️

HaraldPanten · 2022-10-11T21:13:29Z

Hello from OCA days!

/ocabot migration purchase_triple_discount /ocabot merge nobump

Thank you Pedro! 🎉

ramiadavid force-pushed the 15.0-mig-purchase_triple_discount branch from 4a5bd13 to 8689c26 Compare May 22, 2022 22:56

ramiadavid mentioned this pull request May 22, 2022

Migration to version 15.0 #1280

Closed

78 tasks

ramiadavid changed the title ~~[MIG] purchase_triple_discount: Migration to 15.0~~ [15.0][MIG] purchase_triple_discount: May 23, 2022

ramiadavid changed the title ~~[15.0][MIG] purchase_triple_discount:~~ [15.0][MIG] purchase_triple_discount May 23, 2022

ramiadavid force-pushed the 15.0-mig-purchase_triple_discount branch 2 times, most recently from 98acbb5 to 31a0c12 Compare July 5, 2022 17:53

ramiadavid force-pushed the 15.0-mig-purchase_triple_discount branch from 31a0c12 to ba3bdb0 Compare September 6, 2022 21:18

ramiadavid force-pushed the 15.0-mig-purchase_triple_discount branch from ba3bdb0 to 52e6bf8 Compare October 2, 2022 15:40

bi-landoo approved these changes Oct 4, 2022

View reviewed changes

chienandalu and others added 18 commits October 4, 2022 13:39

[ADD] purchase_triple_discount: New module

b92c55b

[FIX] purchase_triple_discount: Correct view inheritance

85c5f24

OCA Transbot updated translations from Transifex

fb6ab1b

[MIG] purchase_triple_discount: Migration to 11.0

9ca16a9

[MIG] purchase_triple_discount

d95cd91

- remove dependency to obsolete module product_supplierinfo_discount - rename procurement.rule into stock.rule - Use new hook introduced in purchase_discount V12 to add discount2 and discount3 - Introduce discount2 and discount3 in purchase.report model

[IMP] inheritance between purchase_discount and purchase_triple_disco…

db03f90

…unt, adding hook

[IMP] purchase*_discount: Several improvements:

0967f7b

* Lighter algorithm when synchronizing PO line info to product.supplierinfo. * Use new create multi method for performance. * Better SQL expresion in purchase report for decreasing the number of operations. * Add test for purchase report.

[UPD] Update purchase_triple_discount.pot

bbd7521

[UPD] README.rst

961f6f8

purchase_triple_discount 12.0.1.0.1

39cc75e

Added translation using Weblate (Chinese (Simplified))

1901bf8

[FIX] purchase_triple_discount: Missing return raises error

e598b8e

purchase_triple_discount 12.0.1.0.2

b6108be

[FIX] purchase_triple_discount: bad display of discounts 2 and 3 in s…

dd694a1

…upplierinfo form view

ChrisOForgeFlow and others added 8 commits October 4, 2022 13:39

[14.0][MIG] purchase_triple_discount

e04746b

[UPD] Update purchase_triple_discount.pot

cc81135

[UPD] README.rst

4bd1ae8

[IMP] update dotfiles [ci skip]

eb15f71

[FIX] purchase_triple_discount: decimal_precision is obsolete

9649f11

purchase_triple_discount 14.0.1.0.1

bfe7cea

[IMP] purchase_triple_discount: Display discount2 and discount3 field…

a72c340

…s on purchase report (cherry picked from commit 6e5b652)

[IMP] purchase_triple_discount: black, isort, prettier

63d1ca9

ramiadavid force-pushed the 15.0-mig-purchase_triple_discount branch from 52e6bf8 to 6b80937 Compare October 4, 2022 11:48

[MIG] purchase_triple_discount: Migration to 15.0

c6ef161

ramiadavid force-pushed the 15.0-mig-purchase_triple_discount branch from 6b80937 to c6ef161 Compare October 4, 2022 12:27

ao-landoo approved these changes Oct 6, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 6, 2022

ma-landoo approved these changes Oct 6, 2022

View reviewed changes

manuelregidor approved these changes Oct 10, 2022

View reviewed changes

HaraldPanten approved these changes Oct 10, 2022

View reviewed changes

OCA-git-bot added this to the 15.0 milestone Oct 11, 2022

OCA-git-bot added the bot is merging ⏳ label Oct 11, 2022

OCA-git-bot merged commit 243b69b into OCA:15.0 Oct 11, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 11, 2022

Uh oh!

Conversation

ramiadavid commented Apr 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramiadavid commented Sep 6, 2022

Uh oh!

oca-clabot commented Oct 2, 2022

Uh oh!

ao-landoo commented Oct 4, 2022

Uh oh!

ramiadavid commented Oct 5, 2022

Uh oh!

ao-landoo left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 6, 2022

Uh oh!

manuelregidor left a comment

Choose a reason for hiding this comment

Uh oh!

HaraldPanten commented Oct 10, 2022

Uh oh!

bi-landoo commented Oct 11, 2022

Uh oh!

pedrobaeza commented Oct 11, 2022

Uh oh!

OCA-git-bot commented Oct 11, 2022

Uh oh!

OCA-git-bot commented Oct 11, 2022

Uh oh!

HaraldPanten commented Oct 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

ramiadavid commented Apr 26, 2022 •

edited

Loading