Skip to content

[15.0][FIX] purchase_blanket_order: Set name by sequence only if is necessary. #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Jul 1, 2022
Merged

[15.0][FIX] purchase_blanket_order: Set name by sequence only if is necessary. #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions purchase_blanket_order/models/blanket_orders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,15 @@ def set_to_draft(self):
def action_confirm(self):
self._validate()
for order in self:
sequence_obj = self.env["ir.sequence"]
if order.company_id:
sequence_obj = sequence_obj.with_company(order.company_id)
name = sequence_obj.next_by_code("purchase.blanket.order")
order.write({"confirmed": True, "name": name})
vals = {"confirmed": True}
# Set name by sequence only if is necessary
if order.name == _("Draft"):
sequence_obj = self.env["ir.sequence"]
if order.company_id:
sequence_obj = sequence_obj.with_company(order.company_id)
name = sequence_obj.next_by_code("purchase.blanket.order") or _("Draft")
vals.update({"name": name})
order.write(vals)
return True

def action_cancel(self):
Expand Down
4 changes: 4 additions & 0 deletions purchase_blanket_order/tests/test_purchase_blanket_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,17 @@ def test_01_create_blanket_order_flow(self):
blanket_order.sudo().action_confirm()

blanket_order.validity_date = fields.Date.to_string(self.tomorrow)
initial_name = blanket_order.name
blanket_order.sudo().action_confirm()
self.assertNotEqual(initial_name, blanket_order.name)

blanket_order.sudo().action_cancel()
self.assertEqual(blanket_order.state, "expired")
blanket_order.sudo().set_to_draft()
self.assertEqual(blanket_order.state, "draft")
previous_name = blanket_order.name
blanket_order.sudo().action_confirm()
self.assertEqual(previous_name, blanket_order.name)

self.assertEqual(blanket_order.state, "open")
blanket_order.action_view_purchase_blanket_order_line()
Expand Down