[15.0][MIG] purchase_order_uninvoiced_amount: Migration to version 15.0#1609
Merged
OCA-git-bot merged 18 commits intoOCA:15.0from Nov 8, 2022
Merged
Conversation
…iscount If we use such module, the final price is not the PO line price unit, so we need to extract the unit price from the subtotal divided by the quantity instead for getting a proper result on both cases. TT25368
…oice policy of the products.
…e_order_view_tree
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_uninvoiced_amount Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_uninvoiced_amount/
… 100 If using purchase_discount, and having one line with discount = 100, line.price_subtotal / line.product_qty was evaluated as falsy, and thus the unit price is taken, returning an incorrect amount. We avoid the problem using if/else Python unary operation instead of and/or expression.
…grouped sum values in purchase tree view TT38874
victoralmau
suggested changes
Oct 26, 2022
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
Please rebase to solve some test warnings.
sergio-teruel
force-pushed
the
15.0-mig-purchase_order_uninvoiced_amount
branch
from
43ad55a to
ae5db77
Compare
Contributor
Author
|
@victoralmau Changes done!! |
Member
|
Tests fail, could you check it? |
Contributor
Author
|
Yes.. I know... |
sergio-teruel
force-pushed
the
15.0-mig-purchase_order_uninvoiced_amount
branch
from
ae5db77 to
e9ecb29
Compare
Contributor
Author
|
Tests fixed!! |
victoralmau
suggested changes
Oct 26, 2022
carlosdauden
approved these changes
Nov 7, 2022
Contributor
|
This PR has the |
Member
|
/ocabot migration purchase_order_uninvoiced_amount |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 3cc3f65. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT36510
ping @carlosdauden @victoralmau