[15.0][IMP] purchase_discount: remove discount compute hacks#2384
[15.0][IMP] purchase_discount: remove discount compute hacks#2384OCA-git-bot merged 1 commit intoOCA:15.0from
Conversation
|
Do the github actions Odoo repo work with some cache? |
|
This is really something of OCA. The image |
Because we put the fix already there some months ago |
As odoo/odoo@1040381 is finally accepted, we can get rid of the previous discount computation hacks. TT45385
b9f6f95 to
e38777a
Compare
|
Now is green :) |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c60a1d7. Thanks a lot for contributing to OCA. ❤️ |
|
@chienandalu I am migrating the module "base_duplicate_security_group" to version 17.0 but I have many errors, can you please help me? angeduar95@gmail.com |
|
@Angeduar you don't need it anymore in v17 as Odoo has incorporated at last the discount mechanism in purchase orders. |
|
@chienandalu i don't said "discount mechanism in purchase orders", i talked about other module that you maked it (base_duplicate_security_group) for OCA. but i resolved the problem and migrate it to v17.0. Thanks |
|
Oh, right. I responded to fast and as you wrote in this PR that has nothing to do with that module I didn't catch that part :S |
As odoo/odoo@1040381 is finally accepted, we can get rid of the previous discount computation hacks.
cc @Tecnativa TT45385
review @pedrobaeza @victoralmau