Skip to content

[15.0][IMP] purchase_discount: remove discount compute hacks#2384

Merged
OCA-git-bot merged 1 commit intoOCA:15.0from
Tecnativa:15.0-imp-purchase_discount-rm-hacks
Aug 8, 2024
Merged

[15.0][IMP] purchase_discount: remove discount compute hacks#2384
OCA-git-bot merged 1 commit intoOCA:15.0from
Tecnativa:15.0-imp-purchase_discount-rm-hacks

Conversation

@chienandalu
Copy link
Copy Markdown
Member

As odoo/odoo@1040381 is finally accepted, we can get rid of the previous discount computation hacks.

cc @Tecnativa TT45385

review @pedrobaeza @victoralmau

@pedrobaeza pedrobaeza added this to the 15.0 milestone Aug 7, 2024
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!!

@chienandalu
Copy link
Copy Markdown
Member Author

Do the github actions Odoo repo work with some cache?

@pedrobaeza
Copy link
Copy Markdown
Member

This is really something of OCA. The image oca-ci or something is built each night with the base code, and it won't work till the next day of the merge. What surprises me is that OCB didn't fail.

@chienandalu
Copy link
Copy Markdown
Member Author

What surprises me is that OCB didn't fail.

Because we put the fix already there some months ago

As odoo/odoo@1040381
is finally accepted, we can get rid of the previous discount computation
hacks.

TT45385
@chienandalu chienandalu force-pushed the 15.0-imp-purchase_discount-rm-hacks branch from b9f6f95 to e38777a Compare August 8, 2024 05:30
@chienandalu
Copy link
Copy Markdown
Member Author

chienandalu commented Aug 8, 2024

Now is green :)

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2384-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 75b5e95 into OCA:15.0 Aug 8, 2024
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c60a1d7. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-purchase_discount-rm-hacks branch August 8, 2024 07:19
@pedrobaeza pedrobaeza changed the title [IMP] purchase_discount: remove discount compute hacks [15.0+[IMP] purchase_discount: remove discount compute hacks Aug 8, 2024
@pedrobaeza pedrobaeza changed the title [15.0+[IMP] purchase_discount: remove discount compute hacks [15.0][IMP] purchase_discount: remove discount compute hacks Aug 8, 2024
@Angeduar
Copy link
Copy Markdown

Angeduar commented Aug 15, 2024

@chienandalu I am migrating the module "base_duplicate_security_group" to version 17.0 but I have many errors, can you please help me? angeduar95@gmail.com

@chienandalu
Copy link
Copy Markdown
Member Author

@Angeduar you don't need it anymore in v17 as Odoo has incorporated at last the discount mechanism in purchase orders.

@Angeduar
Copy link
Copy Markdown

@chienandalu i don't said "discount mechanism in purchase orders", i talked about other module that you maked it (base_duplicate_security_group) for OCA. but i resolved the problem and migrate it to v17.0.

Thanks

@chienandalu
Copy link
Copy Markdown
Member Author

Oh, right. I responded to fast and as you wrote in this PR that has nothing to do with that module I didn't catch that part :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants