Skip to content

[15.0][ADD] stock_move_purchase_price_update: New module#2405

Merged
OCA-git-bot merged 2 commits intoOCA:15.0from
Tecnativa:15.0-ADD-stock_move_purchase_price_update
Oct 22, 2024
Merged

[15.0][ADD] stock_move_purchase_price_update: New module#2405
OCA-git-bot merged 2 commits intoOCA:15.0from
Tecnativa:15.0-ADD-stock_move_purchase_price_update

Conversation

@carlosdauden
Copy link
Copy Markdown
Contributor

@carlosdauden carlosdauden commented Sep 13, 2024

sergio-teruel
sergio-teruel suggested changes Sep 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes... But please create a new module for batch pickins.. I'm sorry for this

Comment thread stock_move_purchase_price_update/__manifest__.py Outdated
Comment thread stock_move_purchase_price_update/__manifest__.py Outdated
@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_move_purchase_price_update branch from d366580 to 01ea880 Compare September 13, 2024 09:17
@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_move_purchase_price_update branch from 01ea880 to 59a2aa6 Compare September 13, 2024 09:43
@carlosdauden
Copy link
Copy Markdown
Contributor Author

carlosdauden commented Sep 13, 2024

Changes done

@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_move_purchase_price_update branch 2 times, most recently from 563bc16 to 21c173d Compare September 13, 2024 10:16
sergio-teruel
sergio-teruel approved these changes Sep 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!!

carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Sep 13, 2024
View reviewed changes
Comment thread stock_move_purchase_price_update/readme/USAGE.md Outdated
@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_move_purchase_price_update branch from 21c173d to e018b38 Compare September 13, 2024 13:55
@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 13, 2024
carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Sep 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

carlos-lopez-tecnativa commented Sep 13, 2024

Only a remark to include as a note in the README (if applicable):
If I receive a partial first picking and change the price to 100, and later receive the remaining and change the price to 110, all pickings will show a unit price of 110 (including the first picking, because it is taken from the purchase line, which is correct).

However, you can add to the README that the price on the picking reflects the purchase price for all pickings and is not individual for each picking. This can be confusing for users who expect each picking to save its unit price independently.

@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_move_purchase_price_update branch from e018b38 to 67f0c34 Compare September 17, 2024 11:44
@carlosdauden
Copy link
Copy Markdown
Contributor Author

carlosdauden commented Sep 17, 2024

@carlos-lopez-tecnativa Added notice in description

@HviorForgeFlow
Copy link
Copy Markdown
Member

HviorForgeFlow commented Oct 22, 2024

@carlosdauden what is the status of this PR?

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 22, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Oct 22, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 22, 2024

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2405-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 51c85e5 into OCA:15.0 Oct 22, 2024
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Oct 22, 2024

Congratulations, your PR was merged at fd59c26. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-ADD-stock_move_purchase_price_update branch October 22, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

6 participants

@carlosdauden @carlos-lopez-tecnativa @HviorForgeFlow @OCA-git-bot @pedrobaeza @sergio-teruel