[15.0][FIX] purchase_requisition_grouped_by_procurement: Correct grouping of purchase requisitions#2475
Merged
OCA-git-bot merged 1 commit intoOCA:15.0from Dec 4, 2024
Conversation
…f purchase requisitions Before this commit, if products had different customer_lead values, separate purchase.requisition records were incorrectly created instead of being grouped into a single record as intended. Steps to reproduce: - Install the Sales module. - Configure two products with the following settings: - Different customer_lead values. - Procurement set to Propose a call for tenders. - Route set to Make to Order (MTO) and Buy. - Create a sales order with the two products and confirm it. - Go to Purchase > Purchase Agreements and search by the sales order name. Issue: Two purchase requisition records are created instead of the expected single record. Solution: This fix ensures that purchase requisitions are grouped correctly, even when products have different customer_lead values.
Contributor
|
Hi @victoralmau, |
victoralmau
approved these changes
Nov 29, 2024
Member
|
/ocabot merge patch |
1 similar comment
Member
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 4, 2024
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 1cf6ab9. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-fix-purchase_requisition_grouped_by_procurement
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, if products had different customer_lead values, separate purchase.requisition records were incorrectly created instead of being grouped into a single record as intended.
Steps to reproduce:
Issue: Two purchase requisition records are created instead of the expected single record.
Solution: This fix ensures that purchase requisitions are grouped correctly, even when products have different customer_lead values.
fwd-port of #2473
TT51858
@Tecnativa @pedrobaeza @victoralmau could you please review this