Skip to content

[16.0][IMP] purchase_order_supplierinfo_update : also synchronize discount from PO lines to supplierinfo (and other fields) #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 16.0
Choose a base branch
from

Conversation

arnaudlayec
Copy link

It can be useful to synchronize other fields from PO lines to supplierinfo prices, like discount from the module purchase_discount or discount1/2/3 from purchase_discount_triple.
This update allow it without hard dependency with such modules purchase_discount or purchase_discount_triple by verifying if the field exists in PO lines and supplierinfo models before trying to write it.

Finally the method _get_synch_fields_line_to_supplierinfo() can be inherited to add other fields to synchronize from PO lines to supplierinfo.

@OCA-git-bot
Copy link
Contributor

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

Copy link

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some review inline.

arnaudlayec and others added 2 commits May 16, 2025 15:20
compatibility between `purchase_discount` and `purchase_triple_discount`
@legalsylvain
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants