Skip to content

[18.0][MIG] purchase_order_line_sequence: Migration to 18.0 #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jun 11, 2025

Conversation

AEstLo
Copy link
Contributor

@AEstLo AEstLo commented Jun 6, 2025

SerpentCS and others added 30 commits June 6, 2025 16:33
If the creation of purchase order lines is made with form view rather than tree view then the module misbehaves, ie, creates a line with sequence 9999. This fixes that without breaking the tree view usage. It also makes sure that the sequence is kept when duplicating a purchase order, which makes more sense. It seems that this was a typo/bug on the original module which was not manifestating when using tree view but becomes clear when allowing editing of the purchase order line with form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/
Currently translated at 88.9% (8 of 9 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_sequence/fr/
After odoo/odoo@49b143e

the sequence is correctly transmitted from purchase line to invoice line.
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_line_sequence/es/
@AEstLo AEstLo force-pushed the 18.0-mig-purchase_order_line_sequence branch from e33351d to f81fe91 Compare June 6, 2025 15:30
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a small change request because product.template in Odoo 18 can no longer have type 'product' (instead, type 'consu' + 'is_storable' True, but this is not relevant here).

@AEstLo AEstLo changed the title [MIG] purchase_order_line_sequence: Migration to 18.0 [18.0][MIG] purchase_order_line_sequence: Migration to 18.0 Jun 7, 2025
@StefanRijnhart
Copy link
Member

/ocabot migration purchase_order_line_sequence

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jun 9, 2025
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AEstLo
Copy link
Contributor Author

AEstLo commented Jun 10, 2025

@StefanRijnhart sorry, I clicked by mistake on request a review

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem!

@AEstLo
Copy link
Contributor Author

AEstLo commented Jun 10, 2025

@StefanRijnhart do you think we can merge it? I saw you merged other migrations for this module :)

@StefanRijnhart
Copy link
Member

Let's give it the standard cooling period of 5 days. I can merge tomorrow.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-2709-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 419e88f into OCA:18.0 Jun 11, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6164e38. Thanks a lot for contributing to OCA. ❤️

@AEstLo AEstLo deleted the 18.0-mig-purchase_order_line_sequence branch June 12, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.