Open
Conversation
sbejaoui
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
from
ddc5d42 to
0527711
Compare
sbejaoui
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
from
0527711 to
aa305f9
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
lmignon
approved these changes
Jan 5, 2026
github-actions
Bot
removed
the
stale
sbejaoui
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
4 times, most recently
from
833666c to
8f1bb67
Compare
nicolas-delbovier-acsone
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
from
6d52a43 to
019c179
Compare
OCA-git-bot
added
mod:repair_stock_consumption_step
In the base repair module, consumption moves for spare parts are created and immediately validated when the repair order is marked as done. This prevents user interaction such as choosing lot/serial numbers. This module introduces an optional intermediate step: - When enabled at warehouse level, repair consumption moves are grouped into a stock picking. - The repair order is set to a new **Consumption** state until the picking is validated. - Users can process the picking manually, assign lots/serials, and only then complete the repair.
…o consumption picking
…ith "repair_stock_move"
…before "done" in form view
…le repair line for same product
nicolas-delbovier-acsone
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
from
fd4dbe9 to
e999245
Compare
lmignon
suggested changes
Apr 15, 2026
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
@nicolas-delbovier-acsone I found a little bug into your last changes...
Comment on lines
+34
to
+35
| for pick in self: | ||
| repair = pick.consumption_repair_order_id |
There was a problem hiding this comment.
@nicolas-delbovier-acsone Be careful to only take into account piking linked to a repair order.
| if partial_consumption_picks := partially_processed_pickings.filtered( | ||
| "consumption_repair_order_id" | ||
| ): | ||
| self._check_no_partial_qties_on_repaired_product() |
There was a problem hiding this comment.
partial_consumption_picks._check_no_partial_qties_on_repaired_product()
nicolas-delbovier-acsone
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
from
e999245 to
1659123
Compare
nicolas-delbovier-acsone
force-pushed
the
16.0-repair_stock_consumption_step-sbj
branch
from
1659123 to
350995f
Compare
…cancelling the repair
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the base repair module, consumption moves for spare parts are created and immediately validated when the repair order is marked as done. This prevents user interaction such as choosing lot/serial numbers.
This module introduces an optional intermediate step:
cc/ @lmignon , @rousseldenis