Add AI repositories and PSC#94
Conversation
|
@etobella regarding the repo name: what is it for? Odoo modules dealing w/ AI or tools for community... or...? |
|
AI modules for Odoo. Mainly widgets to interact with external services (like n8n) in a natural way. Also, I understand that other people will work on other topics. |
|
but then I'd classify them... like |
|
The separation is not clear. Also, it is not clear if Odoo will provide a way to have AI in backend in CE (probably in EE). I would prefer to keep a single repository and split it in the future if necessary, at the end, a lot of people is talking about it, but no real PRs so far |
|
Not sure why you say there are no real PR - we've built a whole functional framework for LLM on top of Odoo - happy to merge this into OCA. |
|
@ayushin You made your own repository outside OCA. The same happens in other cases. However, IMO, the separation is clear: "It is inside OCA or it is not". You had 4 months to ask for the creation of the repository (you can do it yourself by creating a PR in this repo) and the creation of the PR. You didn't do it and you asked people to go to your own repository. I know that it is open right now, but that might change over time (we have seen it happening with Odoo, isn't it?). For this reason, I prefer to use only OCA (Safer for me and my customers). If you want to port it to OCA, feel free to do it, we will be happy with it and I will review if possible, of course 😄 . |
|
I didn’t create this in OCA because I didn’t have time to deal with the process and politics. That’s why we released it under LGPL-3 and asked for help to port it into OCA. |
|
But it is outside OCA, no review from third parties... I understand you did an amazing job and I would like to see it at some point, but right now, as you showed, it is in your hands. I understand that giving the code to OCA might take some time (creation of the repo usually takes less than a day, and the PR could have been created just after that), however, IMO, the effort is lower than the benefits. However, this is my own opinion. Also, you can ask for help for porting, but at the end, you can start the work yourself. In my experience, people will usually help improving the code later on (the same happend to me with the In any case, I think that here we shouldn't discuss about this. We should be happy, as we did the creation of the repo, and now you can port it easily. |
|
Do you recon I should just PR the llm* modules into the ai repo then? |
|
You can make a PR and see what happens. However, it would be better to make it one by one if you expect reviews. If you add 20 modules at the same time, it will never be accepted. Also, unit tests are expected (I made a quick review and you did none). The same with the number of modules. You did too many modules, you can join some of them. Also, avoid external libraries if possible (you did something for a json editor for example, but that shouldn't be necessary) In any case, it would be interesting to check if Odoo opens the IA that they are making into Core or not. In the first case, you should adapt to it. In the second one, you can leave it as it is. |
We would like to start working on it.
@OCA/board @pedrobaeza