Skip to content

Add AI repositories and PSC#94

Merged
simahawk merged 1 commit intoOCA:masterfrom
dixmit:ia
Jun 6, 2025
Merged

Add AI repositories and PSC#94
simahawk merged 1 commit intoOCA:masterfrom
dixmit:ia

Conversation

@etobella
Copy link
Copy Markdown
Member

@etobella etobella commented Jun 5, 2025

We would like to start working on it.

@OCA/board @pedrobaeza

Copy link
Copy Markdown

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪🏻💪🏻

@simahawk
Copy link
Copy Markdown
Contributor

simahawk commented Jun 5, 2025

@etobella regarding the repo name: what is it for? Odoo modules dealing w/ AI or tools for community... or...?

@etobella
Copy link
Copy Markdown
Member Author

etobella commented Jun 5, 2025

AI modules for Odoo. Mainly widgets to interact with external services (like n8n) in a natural way. Also, I understand that other people will work on other topics.

@simahawk
Copy link
Copy Markdown
Contributor

simahawk commented Jun 5, 2025

but then I'd classify them... like ai-backend and ai-frontend or server-ai (in line w/ existing server-* ).

@etobella
Copy link
Copy Markdown
Member Author

etobella commented Jun 5, 2025

The separation is not clear. Also, it is not clear if Odoo will provide a way to have AI in backend in CE (probably in EE).

I would prefer to keep a single repository and split it in the future if necessary, at the end, a lot of people is talking about it, but no real PRs so far

Copy link
Copy Markdown
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Copy Markdown
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely YES!
LGTM

@simahawk simahawk merged commit 29bd600 into OCA:master Jun 6, 2025
1 check passed
@ayushin
Copy link
Copy Markdown

ayushin commented Jun 8, 2025

Not sure why you say there are no real PR - we've built a whole functional framework for LLM on top of Odoo - happy to merge this into OCA.

https://github.com/apexive/odoo-llm

@etobella
Copy link
Copy Markdown
Member Author

etobella commented Jun 8, 2025

@ayushin You made your own repository outside OCA. The same happens in other cases. However, IMO, the separation is clear: "It is inside OCA or it is not".

You had 4 months to ask for the creation of the repository (you can do it yourself by creating a PR in this repo) and the creation of the PR. You didn't do it and you asked people to go to your own repository. I know that it is open right now, but that might change over time (we have seen it happening with Odoo, isn't it?). For this reason, I prefer to use only OCA (Safer for me and my customers).

If you want to port it to OCA, feel free to do it, we will be happy with it and I will review if possible, of course 😄 .

@ayushin
Copy link
Copy Markdown

ayushin commented Jun 8, 2025

I didn’t create this in OCA because I didn’t have time to deal with the process and politics. That’s why we released it under LGPL-3 and asked for help to port it into OCA.

@etobella
Copy link
Copy Markdown
Member Author

etobella commented Jun 8, 2025

But it is outside OCA, no review from third parties... I understand you did an amazing job and I would like to see it at some point, but right now, as you showed, it is in your hands.

I understand that giving the code to OCA might take some time (creation of the repo usually takes less than a day, and the PR could have been created just after that), however, IMO, the effort is lower than the benefits. However, this is my own opinion.

Also, you can ask for help for porting, but at the end, you can start the work yourself. In my experience, people will usually help improving the code later on (the same happend to me with the account_reconcile_oca.

In any case, I think that here we shouldn't discuss about this. We should be happy, as we did the creation of the repo, and now you can port it easily.

@ayushin
Copy link
Copy Markdown

ayushin commented Jun 8, 2025

Do you recon I should just PR the llm* modules into the ai repo then?

@etobella
Copy link
Copy Markdown
Member Author

etobella commented Jun 8, 2025

You can make a PR and see what happens. However, it would be better to make it one by one if you expect reviews. If you add 20 modules at the same time, it will never be accepted. Also, unit tests are expected (I made a quick review and you did none). The same with the number of modules. You did too many modules, you can join some of them. Also, avoid external libraries if possible (you did something for a json editor for example, but that shouldn't be necessary)

In any case, it would be interesting to check if Odoo opens the IA that they are making into Core or not. In the first case, you should adapt to it. In the second one, you can leave it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants