Skip to content

Split EDI repo (?)#99

Closed
simahawk wants to merge 1 commit intoOCA:masterfrom
simahawk:edi-split
Closed

Split EDI repo (?)#99
simahawk wants to merge 1 commit intoOCA:masterfrom
simahawk:edi-split

Conversation

@simahawk
Copy link
Copy Markdown
Contributor

@simahawk simahawk commented Jun 9, 2025

The EDI repo is quite big and has a huge scope... Shall we take the chance to split it while on v18 there's no specific module migrated?

@OCA/edi-maintainers

Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an EDI maintainer but I drop my opinion/quesitons anyway...

Since the split in v16 with edi-framework, the edi repo only contains 20 modules, some of them are glue modules or the implementation of different standards in different apps (example EDIFACT: base_edifact with their sale order and invoice implementations). What is the benefit on separating these modules that are so closely related?

Maybe I'm not realizing of some extra complexity, so my apologies :)

My 2 cents.

@simahawk
Copy link
Copy Markdown
Contributor Author

simahawk commented Jun 9, 2025

@LoisRForgeFlow maybe you are right regarding the size from 16 on. However, my feeling is that it would cleaner and clearer.... I have no strong argument tho :)

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

@simahawk If a split is needed, I think it makes more sense to do it by standard, like edi-edifact, edi-ubl, etc. The rationale for splitting would be much more easy to understand and apply IMO. E.g: What if you develop edifact_repair? would you need to ask for a new repo edi-repair?

@jbaudoux
Copy link
Copy Markdown
Contributor

jbaudoux commented Jun 9, 2025

The EDI repo is quite big and has a huge scope... Shall we take the chance to split it while on v18 there's no specific module migrated?

@OCA/edi-maintainers

I would keep it as it is so far

@etobella
Copy link
Copy Markdown
Member

etobella commented Jun 9, 2025

I would prefer to not split it.

@simahawk
Copy link
Copy Markdown
Contributor Author

simahawk commented Jun 9, 2025

Ok gents! Thanks for you feedback 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants