[19.0][MIG] base_report_to_printer: Migration to 19.0 #436
+51,615
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate ir_report.py to new API Migrate printing.py to new API Migrate res_users.py to new API Migrate report_xml_action.py to new API Migrate wizard/update_printers.py to new API Better view for wizard Recursion when calling a method with old-style api signature from browse Remove the Lock because it is useless on multiprocess Replace it by a database lock so the different processes are all aware of the lock and the last update timestamp. browse is called often enough to call the update routine (even too much) Implements the print on the new 'report' model Restore the print capability on deprecated reports Update copyrights Improve form view, add search view for printers Update translations, add a string to URI so it is uppercased missing api decorator We need the report in print_document and print options (needed in printer_tray) Move the 'skip_update' right in the browse, it prevents a loop See odoo/odoo#3644 Also, it helps to have the value set/read in context close to each other. Avoid to hits the database too many times to check if the list of printers needs to be refreshed. Keep the last update datetime in cache and invalidate this datetime if is is older than POLL_INTERVAL. Thus, one process won't hit the DB more than 1 time every POLL_INTERVAL (10 seconds currently) to check if it needs to update the list. Refresh the list of printers every 15 seconds instead of 10 Extract a method so it will be easier to override in printer_tray Error on installation of the module Invalidate the cache when the table is created so the table_exists() method returns a fresh value after creation of the table Use a cron instead of threads to update printers status The implementation with threads was blocking the loading of the server in multiprocess. Using a cron will lower the frequency of the updates but at least it is simple and reliable. Fixes OCA#14 Do not write the printer status if it has not changed Avoid unnecessary UPDATE every minute Clean the XML file (remove eval, reindent) Give access to models to all users for reading So they are able to print
[Usability] Auto-add Administrator user to the Print group Make XML code more readable base_report_to_printer: add support for remote CUPS server (not just localhost) More logging and better error handling Add CUPS_HOST in more debug logs
Instead, a notification is displayed to the user. When report.get_pdf() is called on a report that must be printer, it will print the report *and* returns the pdf, thus code that calls directly report.get_pdf() will print the pdf on the printer as expected. Fixes OCA#16
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
By calling `super.get_pdf` in print_document we can encounter trouble with MRO resolution that prevent custom report parser (e.g. override of `get_pdf`) to be called. The fix consist of not calling `super` and prevent multiple call to 'printer.print_document'
* context was lost while getting report * now it will be passed using with_context * could be used for print_options (example: pass copies amount for productlabals)
cups is an external dependency, if it is not installed Odoo will not start. OCA guidelines specify guidelines for External dependencies, code is from there.
* Set api.multi for action called as `object` on view * Merge syleam printers module into base_report_to_printer (OCA#60) * [IMP] Updated unit tests * [FIX] Fixed renamed attributes * [FIX] Remove deleted fields * [IMP] Add printing.server and printing.job models * [IMP] Allow to cancel all jobs, enable, and disable printers * [IMP] Split the cups part of print_document into a new print_file method * [IMP] Updated cron job to run the action_update_jobs method * [ADD] Add a migration script to create a printing server from configuration * [MIG] Migrate base_report_to_printer to v10.0 Removed deprecated methods on printing.printer (replaced by methods on printing.server) * [IMP] Add wkhtmltopdf in travis configuration file * [FIX] base_report_to_printer: Fix Update Job Cron * Fix API issue with Update Job Cron ** Forward Port from 9.0 * [FIX] Fixed the res.users view The string attribute should not be used as a selector, because it is translatable. * [FIX] Fixed the print_document method of report The new API migration was made to @api.multi because of the "cr, uid, ids" signature, but "ids" was the ids of the records to print here, not the report's ids. Also, the new API version of "get_pdf" get directly the ids of the records to print in the standard module, not a recordset. * [FIX] UI is now (un)blocked only when using qweb-pdf reports in standard addons
* FIX format parameter To be able to print files in raw format it's needed to set this parameter. Previous code was not able to print raw files, but it didn't get error because 'format' used on line 107 is assumed as a format funtion, because format parameter was not on this scope. * FIX pep8
Provided steps to installing PyCups
Printer Tray isn't an app Base Report To printer ir.actions.report.xml view xpath error and missing page name Put to before security as security tab doesn't do much and if this module is installed it should be the hero page
Migration of printer_tray to v11 and integration with base_report_to_printer
If the test was run in a database with the `account` module installed, they were failing for 2 reasons: - It was searching for the first report it could find, with the first 5 records to report. This made it load the `account.report_agedpartnerbalance` report, which caused a fake `TypeError: 'NoneType' object has no attribute '__getitem__'` error. - It was running tests without loading the full module graph, thus not getting the default value for the new required `invoice_warn` field. Now tests are run in `post_install` mode to load full module graph, and they use stateless data.
|
@miquelalzanillas seems that we still have the issue reported by @dc-oerp , when the report is configured as 'Sent to printer' it is still being downloaded anyway |
Author
|
Hello @JordiMForgeFlow thanks for the review. I can't reproduce this problem now with the latest fixes. Could you check if this asset is loaded? Is the one that was missing before and if loaded you have to see a notification like this after click on Print button. 
|
miquelalzanillas
force-pushed
the
19.0-mig-base_report_to_printer
branch
3 times, most recently
from
3245b4a to
9cef954
Compare
|
When will this PR get merged? |
JordiMForgeFlow
approved these changes
Jan 7, 2026
Member
|
Are you planning to migrate the base_report_to_label_printer module as well? Thank you |
Author
Hi @Maxime-TC , We'll need two more approvals before this PR can be merged by a PSC. Please feel free to contribute with your review. |
Author
Hello @dc-oerp , No, nothing planned on this module. |
Member
|
@sergijPf could you check once again please? |
sergijPf
reviewed
Jan 9, 2026
sergijPf
left a comment
sergijPf
left a comment
There was a problem hiding this comment.
@miquelalzanillas Thanks once again for your contribution! Could you also be so kind cleanup/fix few test files? (pls. see my comments).
The rest seems ok
miquelalzanillas
force-pushed
the
19.0-mig-base_report_to_printer
branch
2 times, most recently
from
064dd43 to
e788fae
Compare
miquelalzanillas
force-pushed
the
19.0-mig-base_report_to_printer
branch
from
e788fae to
8772a04
Compare
sergijPf
approved these changes
Jan 12, 2026
Contributor
|
This PR has the |
Author
|
Hi @pedrobaeza Do you think this is ready to merge? Thanks. |
Member
|
/ocabot migration base_report_to_printer I'm not the most suitable to decide, as I don't know enough this module. At least one PSC/maintainer should check it. |
Author
Ok, thanks @pedrobaeza |
Author
|
Hi @sebalix I'm seeing that you have merged other migrations of this module. Do you think this is ready to merge? |
|
You can add these changes #442 so that when we print a zpl from the PDA, it is not downloaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration PR introduces a structural refactor of the printing framework by splitting the CUPS-specific implementation out of base_report_to_printer into a new module base_report_to_printer_cups.
The goal is to make base_report_to_printer backend-agnostic, so it can serve as a common base for multiple printing backends and protocols, not limited to CUPS.
Why?
Historically, base_report_to_printer has been tightly coupled to CUPS. This coupling makes it difficult to:
By extracting all CUPS-specific logic into its own module, we establish a cleaner architecture where:
Technical overview