[16.0] [ADD] auth_partner, fastapi_auth_partner #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
force-pushed
the
16.0-add-auth_partner-and-fastapi_auth_partner
branch
3 times, most recently
from
517d033 to
e0a8c37
Compare
paradoxxxzero
force-pushed
the
16.0-add-auth_partner-and-fastapi_auth_partner
branch
3 times, most recently
from
29ea34d to
cdd4f0d
Compare
sebastienbeau
force-pushed
the
16.0-add-auth_partner-and-fastapi_auth_partner
branch
from
3ba0b8c to
b71a156
Compare
paradoxxxzero
force-pushed
the
16.0-add-auth_partner-and-fastapi_auth_partner
branch
from
52b4816 to
cdc1980
Compare
paradoxxxzero
force-pushed
the
16.0-add-auth_partner-and-fastapi_auth_partner
branch
from
cdc1980 to
34236ab
Compare
…inheritance (checking anon partner for instance)
Closed
lmignon
reviewed
Apr 3, 2025
|
|
||
| def _get_app_dependencies_overrides(self): | ||
| res = super()._get_app_dependencies_overrides() | ||
| if self.app == "portal": |
There was a problem hiding this comment.
Suggested change
| if self.app == "portal": | |
| if self.app == "myapp": |
| token=self._generate_set_password_token(), | ||
| ) | ||
|
|
||
| def _set_password(self, directory, token, password): |
There was a problem hiding this comment.
Can you add some comment here, (or in the decode_token method ?) regarding the key_salt ?
I know that you add this logic to make the token usable only one (as the function depend on the encrypted password)
But new contributor need help to understand this logic ?
Thanks
|
@paradoxxxzero Can you take into account the last comments so we can move forward with your proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseeds #404 and implements the separation between a base module
auth_partnerand the fastapi implementationfastapi_auth_partner.This PR also introduces a stateless token for password reset, email validation and impersonation and some fixes and minor improvements.
This is still in testing, hence the draft status