-
-
Notifications
You must be signed in to change notification settings - Fork 329
[18.0][MIG] rest_log #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glitchov
wants to merge
60
commits into
OCA:18.0
Choose a base branch
from
acsone:18.0-mig-rest_log-hda
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] rest_log #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extrapolate feature from OCA/wms/shopfloor.
Previous hook was cloning the table but by doing so SQL sequences and indexes were missing.
This commit odoo/odoo@9a129ca refactored MockRequest which breaks tests.
rest api automatically encode dates properly. Storing full responses can be dangerous if not encoded properly.
Fix regression caused by OCA/pull/147. Unfortunately there's no 100% test cov. I'm gonna fix this soon.
This hook is not needed anymore. If you were using shopfloor before this module was introduced you already migrated data.
Odoo errors now inherit from UserError :/
Some endpoints will not return a dict as expected by the ``_dispatch_with_db_logging`` method (and the other methods called within), but an object of type ``odoo.http.Response``. When that happens, the instance fails to handle it while creating logs (ie: tries to call ``json.dumps()`` on such object, which is not allowed). This patch should fix the issue.
This way we can hook an manipulate data w/out having to decode from JSON back and forth.
Currently translated at 100.0% (41 of 41 strings) Translation: rest-framework-16.0/rest-framework-16.0-rest_log Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-rest_log/it/
Currently translated at 100.0% (41 of 41 strings) Translation: rest-framework-16.0/rest-framework-16.0-rest_log Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-rest_log/it/
edf9494
to
9b70b9e
Compare
9b70b9e
to
5605139
Compare
/ocabot migration rest_log |
@glitchov Thank you for the migration. Can you fix the test plz? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from 16.0