[14.0][IMP] sale_order_revision: 'New Revision' quick button on confirmed Sales Orders#2346
Closed
[14.0][IMP] sale_order_revision: 'New Revision' quick button on confirmed Sales Orders#2346
Conversation
dreispt
changed the title
Contributor
rousseldenis
left a comment
rousseldenis
left a comment
There was a problem hiding this comment.
LGTM. @dreispt Could you add a little test ?
dreispt
force-pushed
the
14-dr-sale_order_revision
branch
2 times, most recently
from
365c5f3 to
1c8be71
Compare
Member
Author
|
@rousseldenis Test added! |
dreispt
force-pushed
the
14-dr-sale_order_revision
branch
from
1c8be71 to
c93def8
Compare
dreispt
force-pushed
the
14-dr-sale_order_revision
branch
3 times, most recently
from
94acad0 to
d87f947
Compare
rousseldenis
approved these changes
Aug 30, 2023
| <button | ||
| name="action_cancel_create_revision" | ||
| states="sale" | ||
| string="New Revision" |
Contributor
There was a problem hiding this comment.
I would have added something to help user to know the current one will be canceled (in string or in help at least)
Contributor
rousseldenis
left a comment
rousseldenis
left a comment
There was a problem hiding this comment.
@dreispt Could you also improve README ?
dreispt
force-pushed
the
14-dr-sale_order_revision
branch
from
d87f947 to
8d3def9
Compare
Member
Author
|
README improved. |
Member
Author
|
@rousseldenis Can this be merged? |
Member
Author
|
Ping @rousseldenis |
This was referenced Jan 27, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.