Skip to content

[16.0][IMP] sale_order_lot_selection: Default company on lot creation, consistent field label#2855

Closed
RLeeOSI wants to merge 1 commit intoOCA:16.0from
ursais:16.0-fix-sale-order-lot-selection
Closed

[16.0][IMP] sale_order_lot_selection: Default company on lot creation, consistent field label#2855
RLeeOSI wants to merge 1 commit intoOCA:16.0from
ursais:16.0-fix-sale-order-lot-selection

Conversation

@RLeeOSI
Copy link
Copy Markdown
Contributor

@RLeeOSI RLeeOSI commented Dec 14, 2023

Current behavior:

  • On creating a lot from a Sale Order Line in the Sale Order form view, the company_id field has no default value, which prevents quick create
  • The field label for lot_id on the Sale Order Line is not consistent with the stock_restrict_lot or stock modules

Improvement:

  • Make the default value for company_id on a stock.lot created from a Sale Order Line the same as the company_id for the order line
  • Change the field label for lot_id on the Sale Order Line to match "Restrict Lot" from stock_restrict_lot module and "Lot/Serial Number" from stock module

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @bodedra,
some modules you are maintaining are being modified, check this out!

@RLeeOSI
Copy link
Copy Markdown
Contributor Author

RLeeOSI commented Dec 21, 2023

@rousseldenis If you don't mind checking this one out as well, it's related to OCA/stock-logistics-workflow#1453

@rousseldenis
Copy link
Copy Markdown
Contributor

@florian-dacosta

Copy link
Copy Markdown
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Can you forward this to v18 please ? @RLeeOSI

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 14, 2025
@rousseldenis
Copy link
Copy Markdown
Contributor

@RLeeOSI Could you rebase ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 28, 2025
@rousseldenis
Copy link
Copy Markdown
Contributor

Closing this as very old. Please feel free to reopen it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants