Skip to content

[16.0][ADD] sale_optional_product_quantity: add module#2911

Closed
dmitriypaulov wants to merge 1 commit intoOCA:16.0from
cetmix:16.0-t3210-sale_optional_product_quantity-add_module
Closed

[16.0][ADD] sale_optional_product_quantity: add module#2911
dmitriypaulov wants to merge 1 commit intoOCA:16.0from
cetmix:16.0-t3210-sale_optional_product_quantity-add_module

Conversation

@dmitriypaulov
Copy link
Copy Markdown

@dmitriypaulov dmitriypaulov commented Jan 22, 2024 •
edited
Loading

Depends on product_optional_product_quantity
With this module optional products quantities in Quotations and Sale Orders are updating accordingly to optional products configuration in Product Template

@dmitriypaulov dmitriypaulov marked this pull request as draft January 22, 2024 10:59
@dmitriypaulov dmitriypaulov changed the title 16.0 t3210 sale optional product quantity add module [16.0][ADD] sale_optional_product_quantity: add module Jan 22, 2024
@dmitriypaulov dmitriypaulov force-pushed the 16.0-t3210-sale_optional_product_quantity-add_module branch 2 times, most recently from 80d0756 to 1854c03 Compare January 31, 2024 16:55
@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Feb 5, 2024

@dmitriypaulov Still draft ?

ivs-cetmix
ivs-cetmix approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

@dmitriypaulov dmitriypaulov force-pushed the 16.0-t3210-sale_optional_product_quantity-add_module branch from 36a653c to 9128294 Compare February 12, 2024 23:49
@dmitriypaulov dmitriypaulov marked this pull request as ready for review February 13, 2024 00:28
@ivs-cetmix
Copy link
Copy Markdown
Member

ivs-cetmix commented Feb 13, 2024

@dmitriypaulov Still draft ?

Hi @rousseldenis it's ready for review now.

@ivs-cetmix ivs-cetmix mentioned this pull request Feb 29, 2024
Merged
DemchukM
DemchukM approved these changes Mar 3, 2024
View reviewed changes
Copy link
Copy Markdown

@DemchukM DemchukM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriypaulov dmitriypaulov force-pushed the 16.0-t3210-sale_optional_product_quantity-add_module branch from 9128294 to bb619a8 Compare March 11, 2024 11:12
@ivs-cetmix
Copy link
Copy Markdown
Member

ivs-cetmix commented Mar 11, 2024

Hey @OCA/crm-sales-marketing-maintainers would be great to have it reviewed. PR that this module depends on is already merged.

@ivs-cetmix
Copy link
Copy Markdown
Member

ivs-cetmix commented Aug 7, 2024

Hi @rousseldenis or any of the @OCA/crm-sales-marketing-maintainers could you please check it? Besides the PR it depends on is already merged long ago.
Thank you in advance!

@rousseldenis rousseldenis added this to the 16.0 milestone Aug 23, 2024
@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Aug 23, 2024

FYI, there is also another repo that could be in your interest : https://github.com/OCA/product-pack/tree/14.0/product_pack

Even if it is not exactly the same aim.

@dmitriypaulov @ivs-cetmix
[16.0][ADD] sale_optional_product_quantity: add option quantity compu…
7835ef0 
…tation

[16.0][ADD] sale_optional_product_quantity: add unmerged dep

[16.0][FIX] sale_optional_product_quantity: fix default quantity assignment

[16.0][FIX] sale_optional_product_quantity: fix quantity issue

[FIX] sale_optional_product_quantity: fix logic according to requirements

[FIX] sale_optional_product_quantity: add only options without configurator

[REM] sale_optional_product_quantity: remove merged dependency
@ivs-cetmix ivs-cetmix force-pushed the 16.0-t3210-sale_optional_product_quantity-add_module branch from bb619a8 to 7835ef0 Compare August 23, 2024 11:20
@ivs-cetmix
Copy link
Copy Markdown
Member

ivs-cetmix commented Aug 23, 2024

FYI, there is also another repo that could be in your interest : https://github.com/OCA/product-pack/tree/14.0/product_pack

Even if it is not exactly the same aim.

@rousseldenis noted, thank you! Meanwhile I've rebased this PR to include your recent changes

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 31, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 31, 2025
@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Sep 25, 2025

@dmitriypaulov Could you rebase ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 28, 2025
@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Jan 28, 2026

Closing this as very old. Please feel free to reopen it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

+1 more reviewer

@DemchukM DemchukM DemchukM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved needs review

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dmitriypaulov @rousseldenis @ivs-cetmix @DemchukM @OCA-git-bot