Skip to content

[16.0][FIX] sale_quotation_number: Fix hardcoded quotation sequence p…#3213

Closed
aaladro-kernet wants to merge 1 commit intoOCA:16.0from
aaladro-kernet:16.0-fix-sale_quotation_number-sequence-prefix
Closed

[16.0][FIX] sale_quotation_number: Fix hardcoded quotation sequence p…#3213
aaladro-kernet wants to merge 1 commit intoOCA:16.0from
aaladro-kernet:16.0-fix-sale_quotation_number-sequence-prefix

Conversation

@aaladro-kernet
Copy link
Copy Markdown

…refix on sale order confirm

@aaladro-kernet aaladro-kernet force-pushed the 16.0-fix-sale_quotation_number-sequence-prefix branch from 4500f7c to 4ece4e8 Compare June 28, 2024 18:53
@rousseldenis rousseldenis added this to the 16.0 milestone Jul 3, 2024
class SaleOrder(models.Model):
_inherit = "sale.order"

confirmed_before = fields.Boolean(copy=False)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaladro-kernet Thanks for this. I would say this is a little bit too generic. Maybe quotation_number_set or something like that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover, a little test and a migration script (that set that field for 'SQ' quotations) are welcome

Copy link
Copy Markdown
Author

@aaladro-kernet aaladro-kernet Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is simply to control the order, once confirmed, go back to draft and reconfirm. Do not assign a new sequence number. Are we agreed?

This allows us to modify the prefix of the quotation sequence as we wish.

@MohamedOsman7
Copy link
Copy Markdown
Contributor

@rousseldenis @aaladro-kernet i opened another PRs for this issue in all 3 versions.
(17: #3310 , 16: #3309 , 15: #3311)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 8, 2026
@github-actions github-actions bot closed this Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants