[16.0][IMP] sell_only_by_packaging: support negative rounding when converting packaging qty by QuocDuong1306 · Pull Request #3248 · OCA/sale-workflow

QuocDuong1306 · 2024-07-24T01:39:51Z

Currently, on upstream, It's possible to support creating return orders when filling negative quantities in product_uom_qty on Sale Order lines.

This PR will help to round down the product quantities to the nearest multiple of the packaging quantity in that case.

OCA-git-bot · 2024-08-05T10:39:29Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2024-08-20T16:06:36Z

sell_only_by_packaging/models/product_product.py

+                    float_compare(
+                        qty,
+                        0.0,
+                        precision_rounding=0.001,


Why this value and not another ?

@QuocDuong1306

Hi @rousseldenis , I just based on the original one (positive rounding, here). Do you have any suggestion for this rounding?

Yes, of course, using the product rounding.

Thank @rousseldenis for your suggestions, a new commit has been added

rousseldenis

LGTM

rousseldenis · 2024-09-17T07:32:16Z

/ocabot merge minor

OCA-git-bot · 2024-09-17T07:32:27Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3248-by-rousseldenis-bump-minor, awaiting test results.

Signed-off-by rousseldenis

OCA-git-bot · 2024-09-17T07:40:44Z

@rousseldenis The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name sale-workflow --branch 16.0 --addons-dir /tmp/tmp7uf7_sw0 --commit failed with output:

/tmp/tmp7uf7_sw0/sell_only_by_packaging/README.rst:45: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 8, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 3034, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 1282, in bullet
    self.parent += self.unindent_warning('Bullet list')
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 432, in unindent_warning
    return self.reporter.warning('%s ends without a blank line; '
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 224, in warning
    return self.system_message(self.WARNING_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp7uf7_sw0/sell_only_by_packaging/README.rst:45: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.

rousseldenis · 2024-09-19T15:19:12Z

/ocabot rebase

OCA-git-bot · 2024-09-19T15:19:24Z

Congratulations, PR rebased to 16.0.

ivs-cetmix · 2025-05-11T19:42:40Z

/ocabot rebase

…ng packaging qty

OCA-git-bot · 2025-05-11T19:42:47Z

Congratulations, PR rebased to 16.0.

ivs-cetmix · 2025-05-11T19:43:43Z

Hi @QuocDuong1306 , thank you for your contribution! Could you please squash the commits?

ivs-cetmix · 2025-05-11T19:45:48Z

sell_only_by_packaging/README.rst

-For example, if your packaging is set to sell by 5 units and the employee fill
-the quantity with 3, the quantity will be automatically replaced by 5 (it always rounds up).
+For example, 
+- To sell packaging (fill positive product quantities), if your packaging is set to sell by 5 units and the employee fill


Please add a blank line before the list, like this:

For example: - To sell....

cyrilmanuel · 2026-02-02T08:00:25Z

@QuocDuong1306 hi, could you make the modification to let this pr be merge please :) thanks a lot for your effort

alexey-pelykh

Thanks for working on this, nice addition for return order support.

The rounding logic in _convert_packaging_qty looks correct to me -- the forced_qty -= q adjustment for negative quantities properly rounds away from zero (toward more negative), which is the expected mirror of the existing round-up behavior for positive quantities.

Good catch also on switching precision_rounding=0.001 to precision_rounding=uom.rounding -- using the UoM's actual precision is more correct than the hardcoded value.

Tests cover the key negative-qty scenarios well.

Two things still needed before this can merge:

The RST formatting issue that @ivs-cetmix already flagged in README.rst also exists in readme/DESCRIPTION.rst (same source). The bullet list needs a blank line before it and the continuation lines should be indented to align with the list item text. This is what caused oca-gen-addon-readme to fail on the previous merge attempt.
Commits need squashing as requested.

cyrilmanuel · 2026-03-05T08:55:26Z

hi guys, i've superseed this pr here --> #4196

you can close this one :)

rousseldenis · 2026-03-10T12:18:45Z

Closing as solved by: #4196

yankinmax approved these changes Jul 26, 2024

View reviewed changes

cyrilmanuel approved these changes Aug 5, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Aug 5, 2024

rousseldenis reviewed Aug 20, 2024

View reviewed changes

rousseldenis approved these changes Sep 17, 2024

View reviewed changes

rousseldenis added this to the 16.0 milestone Sep 17, 2024

OCA-git-bot added a commit that referenced this pull request Sep 17, 2024

Merge PR #3248 into 16.0

a80ea8e

Signed-off-by rousseldenis

OCA-git-bot added the bot is merging ⏳ label Sep 17, 2024

OCA-git-bot removed the bot is merging ⏳ label Sep 17, 2024

OCA-git-bot force-pushed the 16.0-imp-sell_only_by_packaging branch from 93569c4 to f8637f8 Compare September 19, 2024 15:19

duongtq and others added 2 commits May 11, 2025 19:42

[IMP] sell_only_by_packaging: support negative rounding when converti…

eb82866

…ng packaging qty

[IMP] sell_only_by_packaging: convert qty should use product rounding

444f5da

OCA-git-bot force-pushed the 16.0-imp-sell_only_by_packaging branch from f8637f8 to 444f5da Compare May 11, 2025 19:42

ivs-cetmix requested changes May 11, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels May 11, 2025

alexey-pelykh reviewed Mar 3, 2026

View reviewed changes

cyrilmanuel approved these changes Mar 5, 2026

View reviewed changes

cyrilmanuel mentioned this pull request Mar 5, 2026

[16.0][IMP] sell_only_by_packaging: support negative rounding when converting packaging qty and use product rounding #4196

Merged

rousseldenis closed this Mar 10, 2026

Uh oh!

Conversation

QuocDuong1306 commented Jul 24, 2024

Uh oh!

OCA-git-bot commented Aug 5, 2024

Uh oh!

rousseldenis Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

rousseldenis Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

QuocDuong1306 Aug 23, 2024

Choose a reason for hiding this comment

Uh oh!

rousseldenis Aug 23, 2024

Choose a reason for hiding this comment

Uh oh!

QuocDuong1306 Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Sep 17, 2024

Uh oh!

OCA-git-bot commented Sep 17, 2024

Uh oh!

OCA-git-bot commented Sep 17, 2024

Uh oh!

rousseldenis commented Sep 19, 2024

Uh oh!

OCA-git-bot commented Sep 19, 2024

Uh oh!

ivs-cetmix commented May 11, 2025

Uh oh!

OCA-git-bot commented May 11, 2025

Uh oh!

ivs-cetmix commented May 11, 2025

Uh oh!

ivs-cetmix May 11, 2025

Choose a reason for hiding this comment

Uh oh!

cyrilmanuel commented Feb 2, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

cyrilmanuel commented Mar 5, 2026

Uh oh!

rousseldenis commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants