[FIX] sale_company_currency: Changes on sale_order_currency_rate#3261
Closed
[FIX] sale_company_currency: Changes on sale_order_currency_rate#3261
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module
sale_company_currency
Describe the bug
The problem was the Total (company currency) field (
amount_total_curr) was bad calculated as I explained in the PR. However, the field was not incorrect, the incorrect value was the currency_rate in sale_order_currency_rate that uses for amount_total_curr's calculation.Because this reason, I have created a new PR #3260 changing the calcultaion of currency_rate as it is in odoo base and explainning the problema more detailed.
Affected versions:
16.0