[16.0] - sale_triple_discount - [BUG] preprocess cache invalidation seems to make updates impossible#3324
Closed
[16.0] - sale_triple_discount - [BUG] preprocess cache invalidation seems to make updates impossible#3324
Conversation
IJOL
force-pushed
the
16.0-sale_triple_discount-fixes-3323
branch
from
d62c83d to
d5cf77b
Compare
Author
|
@pedrobaeza Can you help get some visibility and reach for this one?, is really giving me a hard time, the 16.0 branch doesnt works at all and I need some triage and confirmation, is about to get me mad!! |
IJOL
force-pushed
the
16.0-sale_triple_discount-fixes-3323
branch
from
d1f8fb0 to
381ab47
Compare
Member
|
You can ping the authors/contributors/maintainers of the module. |
Contributor
IJOL
force-pushed
the
16.0-sale_triple_discount-fixes-3323
branch
from
21235cb to
311f494
Compare
…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".
…he module description.
Add POT file Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental Add pt_BR translation, contributed by Caio Barros.
…g because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)
…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.
…a link to the screencast in the module description
…y of the rental features
Update POT file and FR translation Fix translated string in code Slovene translations added OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex remove obsolete .pot files [ci skip] fix invalid pt_BR.po Update sale_rental.pot Translated using Weblate (Nederlands (nl_NL)) Currently translated at 100,0% (99 of 99 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_rental/nl_NL/ Update sale_rental.pot Update translation files Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate. Translated using Weblate (German) Currently translated at 28.3% (28 of 99 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_rental/de/ [REM] Translation file for error
Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field
Currently translated at 40.7% (42 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/
Currently translated at 63.1% (65 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/
Currently translated at 49.5% (51 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 100.0% (103 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/
Currently translated at 100.0% (104 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/
Currently translated at 55.7% (58 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 100.0% (104 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Currently translated at 100.0% (104 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
…updated records in sale.order, with this change seems to solve it and the extension seems working, needs review
IJOL
force-pushed
the
16.0-sale_triple_discount-fixes-3323
branch
from
311f494 to
545c402
Compare
alexey-pelykh
suggested changes
Mar 3, 2026
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for flagging this cache invalidation issue, @IJOL — it was a real pain point.
However, this PR has a couple of problems that prevent it from being mergeable:
-
The diff contains no
sale_triple_discountchanges. The branch only includes the addition of an unrelatedsale_rentalmodule (48k+ lines). The actualsale_triple_discountfix seems to have been lost — possibly after a rebase or force-push gone wrong. -
The underlying issue has already been fixed. PR #3329 was merged on 2024-10-16 and addresses the same cache invalidation problem with a more comprehensive approach (context manager instead of
invalidate_cache).
Given that #3329 already landed, I think this PR can simply be closed. @IJOL could you confirm the issue is resolved on your end with the merged fix?
Author
|
Totally forgot this one, thanks , the problem has been long gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know is really naive but until now it solves the issue AFAIK