[16.0][MIG] sale_mrp_link: Migration to 16.0 (from 12.0) by legalsylvain · Pull Request #3339 · OCA/sale-workflow

legalsylvain · 2024-10-01T08:37:03Z

No description provided.

yvaucher · 2024-10-01T09:30:14Z

/ocabot migration sale_mrp_link

ypapouin · 2025-05-15T09:09:51Z

sale_mrp_link/models/mrp_production.py

+        if "origin" in values:
+            # Checking first if this comes from a 'sale.order'
+            sale_id = self.env["sale.order"].search(
+                [("name", "=", values["origin"])], limit=1
+            )
+            if sale_id:
+                values["sale_order_id"] = sale_id.id
+                if sale_id.client_order_ref:
+                    values["origin"] = sale_id.client_order_ref
+            else:
+                # Checking if this production comes from a route
+                production_id = self.env["mrp.production"].search(
+                    [("name", "=", values["origin"])]
+                )
+                # If so, use the 'sale_order_id' from the parent production
+                values["sale_order_id"] = production_id.sale_order_id.id
+


sale_order_id should not be overridden if already set (by third-party module)

Maybe add a check before:
if "origin" in values and not values.get("sale_order_id"):

Or browse the sale_id first and keep existing code:

if "origin" in values: # Checking first if this comes from a 'sale.order' sale_id = self.env["sale.order"].browse(values.get("sale_order_id")) if not sale_id: sale_id = self.env["sale.order"].search( [("name", "=", values["origin"])], limit=1 )

rousseldenis · 2025-09-29T15:37:13Z

@legalsylvain What's the status of this ?

legalsylvain · 2025-09-29T19:24:33Z

Not sure to know how to finish this work. I didn't developped the module at the beginning, and I'm not sure to know how to address @ypapouin remark, as it is about code I didn't written.

feel free to finish !

ypapouin · 2025-10-06T12:57:37Z

@legalsylvain , just replacing if "origin" in values: with if "origin" in values and not values.get("sale_order_id") should be enough.

github-actions · 2026-03-15T12:50:18Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

… with sale_mrp_link

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/

As mrp.production already has a Many2one field pointing to sale.order it makes sense to have a One2many on the "other side". This adds multiple benefits: - Easier to open linked production with the smart button action - Simpler production count computing (also now can store the result) - Dependent modules can use the One2many field for other purposes

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/fr/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/es/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/ca/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/tr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/

…third-party module

legalsylvain · 2026-03-19T08:45:33Z

Hi @ypapouin and @rousseldenis.

Sorry for the late. PR finished and rebased.
just two new commits to review :

90d5a23 : apply @ypapouin fix.
f8f81e1 : use new api_create_multi decorator.

Could you finish your review ?

Updated : tests are failing. no need to review for the time being.

thanks !

legalsylvain · 2026-03-19T09:17:55Z

In fact, the feature is now native. closing.

odoo/odoo#43366
odoo/odoo@e1b3a17

you can review This OpenUpgrade PR : OCA/OpenUpgrade#5562

OCA-git-bot added this to the 16.0 milestone Oct 1, 2024

OCA-git-bot mentioned this pull request Oct 1, 2024

Migration to version 16.0 #2215

Open

ypapouin reviewed May 15, 2025

View reviewed changes

ypapouin mentioned this pull request Dec 22, 2025

[18.0][MIG] sale_mrp_link: Migration to 18.0 #4080

Open

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 15, 2026

achaussende and others added 20 commits March 19, 2026 09:38

[ADD] sale_mrp_link module

c21ae43

[UPD] Update sale_mrp_link.pot

421af4c

[UPD] README.rst

4aa2c41

[FIX] Also separate test for sale_delivery_split_date as incompatible…

8da29f6

… with sale_mrp_link

[ADD] icon.png

e3ded1f

[UPD] README.rst

9455a63

[MIG] Migration of sale_mrp_link to 12.0

2752a61

[UPD] Update sale_mrp_link.pot

e06fb96

Update translation files

94dd3b3

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/

[UPD] Update sale_mrp_link.pot

1738016

sale_mrp_link 12.0.1.0.1

afe8b6f

Update translation files

7f78a0e

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/

Added translation using Weblate (French)

a266e89

Translated using Weblate (French)

666f77a

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/fr/

Added translation using Weblate (Spanish)

ecb6a62

Translated using Weblate (Spanish)

d81283c

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/es/

Added translation using Weblate (Catalan)

31fd22c

Translated using Weblate (Catalan)

8de54f0

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/ca/

Added translation using Weblate (Turkish)

ae6817a

yavuzavci and others added 7 commits March 19, 2026 09:38

Translated using Weblate (Turkish)

75b1df4

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/tr/

[UPD] README.rst

abd24ff

Update translation files

3053872

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_mrp_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_mrp_link/

[IMP] sale_mrp_link: pre-commit stuff

cbbe604

[MIG] sale_mrp_link: Migration to 16.0 (from 12.0)

74dc5d3

[FIX] sale_mrp_link : avoid to override sale_order_id, if defined by …

90d5a23

…third-party module

[REF] sale_mrp_link: update documentation

7f928a4

legalsylvain force-pushed the 16.0-mig-sale_mrp_link branch from f07d426 to 7f928a4 Compare March 19, 2026 08:41

[IMP] sale_mrp_link : use new api_create_multi decorator

f8f81e1

legalsylvain marked this pull request as ready for review March 19, 2026 08:45

legalsylvain marked this pull request as draft March 19, 2026 09:06

legalsylvain closed this Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[16.0][MIG] sale_mrp_link: Migration to 16.0 (from 12.0)#3339

[16.0][MIG] sale_mrp_link: Migration to 16.0 (from 12.0)#3339
legalsylvain wants to merge 28 commits intoOCA:16.0from
grap:16.0-mig-sale_mrp_link

legalsylvain commented Oct 1, 2024

Uh oh!

yvaucher commented Oct 1, 2024

Uh oh!

ypapouin May 15, 2025

Uh oh!

rousseldenis commented Sep 29, 2025

Uh oh!

legalsylvain commented Sep 29, 2025

Uh oh!

ypapouin commented Oct 6, 2025

Uh oh!

github-actions bot commented Mar 15, 2026

Uh oh!

legalsylvain commented Mar 19, 2026 •

edited

Loading

Uh oh!

legalsylvain commented Mar 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

legalsylvain commented Oct 1, 2024

Uh oh!

yvaucher commented Oct 1, 2024

Uh oh!

ypapouin May 15, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Sep 29, 2025

Uh oh!

legalsylvain commented Sep 29, 2025

Uh oh!

ypapouin commented Oct 6, 2025

Uh oh!

github-actions bot commented Mar 15, 2026

Uh oh!

legalsylvain commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

legalsylvain commented Mar 19, 2026 •

edited

Loading

legalsylvain commented Mar 19, 2026 •

edited

Loading