[18.0][MIG] sale_blanket_order: Migration to 18.0#3370
Closed
BertVGroenendael wants to merge 57 commits intoOCA:18.0from
Closed
[18.0][MIG] sale_blanket_order: Migration to 18.0#3370BertVGroenendael wants to merge 57 commits intoOCA:18.0from
BertVGroenendael wants to merge 57 commits intoOCA:18.0from
Conversation
When duplicating a confirmed blanket order, the new copy shouldn't keep the state nor the sequence number (name).
Steps to reproduce: * create and confirm a blanket order (BO) with (product A, qty 30) and (product B, qty 20) * from the BO create a SO with (product A, qty 10) and (product B, qty 10) * from the BO create a SO with (product A, qty 20) and (product B, qty 0) * from the BO create another SO with (product B, qty 10) Current behavior: It raises the exception "The sale has already been completed.". Expected behavior: No exception is raised.
Currently translated at 7.1% (11 of 154 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/de/
exactly like in sales orders.
* Allow to select an analitic account in the blanket order. It will be passed on to the SO. * Allow to select analytic tags on blanket order lines. They will be passed to the SO lines. * Source document was not being filled in SO created from a blanket order.
…dy set Otherwise use case same as that one written in https://github.com/OCA/sale-workflow/blob/14.0/sale_shipping_info_helper/tests/test_sale_shipping_info_helper.py#L22 fails See https://app.travis-ci.com/github/OCA/sale-workflow/jobs/555432793#L3103-L3107 as reference
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_blanket_order/
Currently translated at 100.0% (169 of 169 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_blanket_order Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_blanket_order/it/
BertVGroenendael
force-pushed
the
18.0-mig-sale_blanket_order
branch
from
aa0a420 to
1151435
Compare
Contributor
|
/ocabot migration sale_blanket_order |
| required=True, | ||
| ) | ||
| currency_id = fields.Many2one("res.currency", related="pricelist_id.currency_id") | ||
| analytic_account_id = fields.Many2one( |
Contributor
There was a problem hiding this comment.
Any replacement for that ?
Member
There was a problem hiding this comment.
Blanket order lines inherit from analytic.mixin, but the values are not transferred without #3294
|
@BertVGroenendael - Is this work still in progress? I am not the most technical person but would love to see this available in V18.... |
| product_currency = None | ||
| if rule_id: | ||
| pricelist_item = PricelistItem.browse(rule_id) | ||
| if pricelist_item.pricelist_id.discount_policy == "without_discount": |
Contributor
There was a problem hiding this comment.
Suggested change
| if pricelist_item.pricelist_id.discount_policy == "without_discount": | |
| if pricelist_item._show_discount(): |
discount_policy field does not exist anymore
Contributor
|
Could you please include the fix #3628 in this PR? Thanks! :) |
Comment on lines
+511
to
+512
| and pricelist_item.base_pricelist_id.discount_policy | ||
| == "without_discount" |
Contributor
There was a problem hiding this comment.
Suggested change
| and pricelist_item.base_pricelist_id.discount_policy | |
| == "without_discount" | |
| and pricelist_item._show_discount() |
Contributor
|
This PR seems stale so we are superseding it soon |
1 task
Contributor
|
@BertVGroenendael We switch to #3642 |
Member
|
I think this should be closed in favor of OCA/sale-blanket#8 that was merged into the sale-blanket repo. Please reopen if I'm wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.