[18.0][MIG] sale_order_lot_selection: Migration to 18.0 by lef-adhoc · Pull Request #3409 · OCA/sale-workflow

lef-adhoc · 2024-11-14T17:46:15Z

Depends on:

[18.0][MIG] stock_restrict_lot: Migration to 18.0 stock-logistics-workflow#1762

pedrobaeza · 2024-11-14T18:14:23Z

Everything is correct. The red CI is there for avoiding to merge this while the dependency is not merged.

/ocabot migration sale_order_lot_selection

Abimael1321 · 2024-11-27T09:23:47Z

Functionally reviewed. LGTM!

[FIX] Fix product_id on test [FIX] Fix product on test

copy

of copy method

[FIX] Use product_14 instead of product_11 [FIX] Add test's flow step

[FIX] change data in quant search [FIX] Fixed tab [FIX] Add check on lots list FIX product_id_change_with_wh

Because quants_get_prefered_domain does not return quants with our lots, if other quants are available

…ot_id field

…roup_production_lot res.groups

Currently translated at 50.0% (3 of 6 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_lot_selection Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_lot_selection/it/

Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_lot_selection Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_lot_selection/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_order_lot_selection Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_order_lot_selection/

matiasperalta1 · 2025-03-06T14:24:57Z

@pedrobaeza Everything seems ok. Could you merge it?

pedrobaeza · 2025-03-06T14:45:16Z

A PSC / maintainer should review it.

rjaraspearhead · 2025-03-12T16:59:03Z

+# © 2015 Agile Business Group
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from odoo.tests import TransactionCase


Suggested change

from odoo.tests import TransactionCase

from odoo.addons.base.tests.common import BaseCommon

It is recommended to use BaseCommon.

rjaraspearhead · 2025-03-12T16:59:26Z

+from odoo.tests import TransactionCase
+
+
+class TestSaleOrderLotSelection(TransactionCase):


Suggested change

class TestSaleOrderLotSelection(TransactionCase):

class TestSaleOrderLotSelection(BaseCommon):

rjaraspearhead

LGM 👍

OCA-git-bot · 2025-03-12T17:26:15Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AEstLo · 2025-03-28T14:47:40Z

@bodedra do you think this can be merged? (as maintainer https://github.com/OCA/sale-workflow/tree/17.0/sale_order_lot_selection#maintainers)

bodedra · 2025-03-29T18:17:56Z

Functional reviewed. 👍

/ocabot merge nobump

OCA-git-bot · 2025-03-29T18:18:09Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3409-by-bodedra-bump-nobump, awaiting test results.

OCA-git-bot · 2025-03-29T18:26:21Z

Congratulations, your PR was merged at bcdbcae. Thanks a lot for contributing to OCA. ❤️

lef-adhoc changed the title ~~[18.0 mig sale order lot selection~~ [18.0][MIG] sale_order_lot_selection: Migration to 18.0 Nov 14, 2024

lef-adhoc force-pushed the 18.0-mig-sale_order_lot_selection branch 2 times, most recently from fa1c869 to 1cd6283 Compare November 14, 2024 18:04

OCA-git-bot added this to the 18.0 milestone Nov 14, 2024

OCA-git-bot mentioned this pull request Nov 14, 2024

Migration to version 18.0 #3344

Open

Abimael1321 approved these changes Nov 27, 2024

View reviewed changes

hurrinico and others added 22 commits March 6, 2025 11:17

[FIX] Add sale order dolder

450145c

[FIX] adds _run_move_create and some other fixes

8540a44

[FIX] add restriction on sale confirm changed icon and minor fix

a7fc2b4

[FIX] Fix product_id on test [FIX] Fix product on test

[FIX] Add check on sale order

0aecda3

[FIX] add _run override

c50a1e0

[FIX] adding feature and fix contributors

7a0519e

Add transmition of lot_id from move to procurement and delete lot_id on

59ed906

copy

Extract move state check for easier inherit and add copy=False instead

3fe1094

of copy method

Fix pep8 and edit check move state

64e3575

Fix unused import

4c419ec

[IMP] better lot names in tests

44f4fc8

[FIX] Fixed Tests adding a stock_picking_in to create quants

a22729f

[FIX] Use product_14 instead of product_11 [FIX] Add test's flow step

[FIX] Add check on lot reservation in test

c53b8f1

[FIX] Add check on quants

83e0a04

[FIX] change data in quant search [FIX] Fixed tab [FIX] Add check on lots list FIX product_id_change_with_wh

Refactoring product_id_change_with_wh for domain generation.

3d77634

Because quants_get_prefered_domain does not return quants with our lots, if other quants are available

Refactoring tests, adding onchange tests

6c818c2

Remove never used domain: on_change will set the correct domain for l…

8bf3c2d

…ot_id field

IMP module version and fix comment

4f64559

the field lot_id should only be visible to the members of the stock.g…

641be31

…roup_production_lot res.groups

REF some code and ADD lot11 has 1 availability and order4 has quantity 2

abacaee

REF product_id_change_with_wh for compatibility with ohter override

ef4f0ef

FIX default value in context

a1c207d

francesco-ooops and others added 12 commits March 6, 2025 11:17

[MIG] sale_order_lot_selection: Migration to 15.0

5877eb3

[MIG][16.0] Migrate sale_order_lot_selection to v16

58efad3

sale_order_lot_selection 16.0.1.0.1

db91607

[IMP] sale_order_lot_selection: black, isort, prettier

8ca3b12

[MIG] sale_order_lot_selection: Migration to 17.0

fd5742f

[UPD] Update sale_order_lot_selection.pot

449f5bf

[BOT] post-merge updates

b2bdcf1

[IMP] sale_order_lot_selection: pre-commit execution

084ae06

[MIG] sale_order_lot_selection: Migration to 18.0

12d20d4

matiasperalta1 force-pushed the 18.0-mig-sale_order_lot_selection branch from 1cd6283 to 12d20d4 Compare March 6, 2025 14:18

rjaraspearhead reviewed Mar 12, 2025

View reviewed changes

rjaraspearhead approved these changes Mar 12, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 12, 2025

rov-adhoc approved these changes Mar 18, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 29, 2025

OCA-git-bot merged commit 6b22fdd into OCA:18.0 Mar 29, 2025
2 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 29, 2025

	from odoo.tests import TransactionCase
	from odoo.addons.base.tests.common import BaseCommon

		from odoo.tests import TransactionCase


		class TestSaleOrderLotSelection(TransactionCase):

	class TestSaleOrderLotSelection(TransactionCase):
	class TestSaleOrderLotSelection(BaseCommon):

Uh oh!

Conversation

lef-adhoc commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Nov 14, 2024

Uh oh!

Abimael1321 commented Nov 27, 2024

Uh oh!

matiasperalta1 commented Mar 6, 2025

Uh oh!

pedrobaeza commented Mar 6, 2025

Uh oh!

rjaraspearhead Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

rjaraspearhead Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

rjaraspearhead left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 12, 2025

Uh oh!

AEstLo commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bodedra commented Mar 29, 2025

Uh oh!

OCA-git-bot commented Mar 29, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Mar 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

lef-adhoc commented Nov 14, 2024 •

edited

Loading

AEstLo commented Mar 28, 2025 •

edited

Loading