Revert "[15][PORT] sale_quotation_number: allow customizable quotation sequence"#3416
Merged
OCA-git-bot merged 1 commit intoOCA:15.0from Nov 20, 2024
Merged
Conversation
Contributor
Author
|
@HaraldPanten Could you review, please? |
HaraldPanten
approved these changes
Nov 20, 2024
pedrobaeza
approved these changes
Nov 20, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Let's revert it while a solution without regressions is found.
/ocabot merge patch
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
THX! @CRogos This PR is important for you. Please, have a look at that. |
Contributor
|
Congratulations, your PR was merged at a897942. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts commit df94b4d, which generates the problems pointed out here: #3310 (comment)
This revert is only applied to v15, as it is the only version in which module sale_quotation_number already dealt with the issues explained in the PR #3310.
I-6628