[18.0][MIG] partner_sale_pivot: Migration to 18.0#3485
[18.0][MIG] partner_sale_pivot: Migration to 18.0#3485OCA-git-bot merged 17 commits intoOCA:18.0from
Conversation
juancarlosonate-tecnativa
left a comment
juancarlosonate-tecnativa
left a comment
There was a problem hiding this comment.
LGTM, functional and code review
@Tecnativa @pedrobaeza TT54209
| <!-- | ||
| In V13.0 the field confirmation_date has been removed. Now the field | ||
| date_order is the confirmation date for orders in 'sale' and 'done' state | ||
| --> |
There was a problem hiding this comment.
maybe this should be removed
There was a problem hiding this comment.
@juancarlosonate-tecnativa, please review.it's done.
BhaveshHeliconia
force-pushed
the
18.0-mig-partner_sale_pivot
branch
from
ea7e9d3 to
e30cbdb
Compare
|
Hey @OCA/crm-sales-marketing-maintainers would be great if someone could have a look at this module. |
DantePereyra
left a comment
DantePereyra
left a comment
There was a problem hiding this comment.
I think README.rst, index.html, and all the modifications introduced by pre-commit should be included in dedicated commit [IMP] partner_sale_pivot: pre-commit auto fixes. Meanwhile, the actual migration logic should go in a separate commit titled [MIG] partner_sale_pivot: Migration to 18.0.
| <record id="sale_report_action" model="ir.actions.act_window"> | ||
| <field name="name">Sales Analysis</field> | ||
| <field name="res_model">sale.report</field> | ||
| <field name="view_mode">pivot</field> |
There was a problem hiding this comment.
See migration notes (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0)
Whenever possible, define the field path on ir.actions.act_window records for a nicer URL.
BhaveshHeliconia
force-pushed
the
18.0-mig-partner_sale_pivot
branch
from
e30cbdb to
b3c6760
Compare
|
@DantePereyra : Please review again. Thanks. |
|
LGTM. Could you try making a few small improvements to the test? It's currently not meeting the requirements on Codecov. |
|
@DantePereyra,Thank you for the suggestion. Since this PR only involves a view definition aligned with Odoo's core structure and doesn't include any business logic or model changes, no test was added |
[UPD] Update partner_sale_pivot.pot [ADD] icon.png
[UPD] Update partner_sale_pivot.pot
TT31330 partner_sale_pivot 13.0.1.1.0
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-partner_sale_pivot Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-partner_sale_pivot/hr/
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-partner_sale_pivot Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-partner_sale_pivot/it/
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-partner_sale_pivot Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-partner_sale_pivot/de/
BhaveshHeliconia
force-pushed
the
18.0-mig-partner_sale_pivot
branch
from
b3c6760 to
0d13f84
Compare
|
This PR has the |
|
/ocabot migration partner_sale_pivot |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 5e9c5b9. Thanks a lot for contributing to OCA. ❤️ |
13 participants
No description provided.